baremetal: update terraform-provider-ironic and use newer API #2571
Conversation
Recent versions of Ironic support sending the config drive data as a JSON blob. Previously we built the ISO on the host installing the cluster, requiring a dependency on mkisofs being installed. This release of the terraform provider will just send the user data and related information directly to Ironic and let it build the ISO, if the Ironic version is new enough.
With 1.56 of the API, we can send Ironic the JSON data for a config drive, rather than a base64-encoded, gzipped ISO9660 image. This avoids a dependency on the host running the installer to have mkisofs available.
|
/label platform/baremetal |
openshift-ci-robot
added
platform/baremetal
|
FYI, regarding the issue you encountered earlier /cc @dhellmann |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1273/ |
|
/approve |
openshift-ci-robot
added
the
approved
|
/test e2e-libvirt |
1 similar comment
|
/test e2e-libvirt |
|
This should be good to merge towards 4.4 now. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, dhellmann, hardys, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/refresh |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
With 1.56 of the Ironic API, we can send Ironic the JSON data for a config
drive, rather than a base64-encoded, gzipped ISO9660 image. This avoids
a dependency on the host running the installer to have mkisofs
available.