Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack UPI: Automate Control Plane creation #2591

Merged
merged 2 commits into from Dec 3, 2019
Merged

openstack UPI: Automate Control Plane creation #2591

merged 2 commits into from Dec 3, 2019

Conversation

pierreprinetti
Copy link
Member

Create an Ansible playbook for deploying the Control Plane required for
a User Provided Infrastructure installation.

Implements https://jira.coreos.com/browse/OSASINFRA-787

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2019
@pierreprinetti
Copy link
Member Author

This PR will remain in a draft state until #2580 is approved.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2019
@pierreprinetti
Copy link
Member Author

/label platform/openstack

@pierreprinetti pierreprinetti marked this pull request as ready for review October 31, 2019 14:06
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2019
@pierreprinetti
Copy link
Member Author

/retest
/hold

while we figure out whether this can be merged during Feature Freeze.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2019
@pierreprinetti
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2019
@iamemilio
Copy link

/retest

tomassedovic
tomassedovic suggested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@tomassedovic tomassedovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the default control plane node count is incorrect.

upi/openstack/inventory.yaml Outdated Show resolved Hide resolved
tomassedovic
tomassedovic suggested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@tomassedovic tomassedovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error in providing the userdata contents.

Also, the indices should be 0-based. That's what IPI and UPI does currently (and also, what AFAIK) all the other platforms do.

I'm not opposed to having 1-based indices, but that should be a separate change and it will probably have to be coordinated with the other platforms too.

upi/openstack/04_control-plane.yaml Outdated Show resolved Hide resolved
upi/openstack/04_control-plane.yaml Outdated Show resolved Hide resolved
@pierreprinetti
openstack UPI: Automate Control Plane creation
54bfe19 
Create an Ansible playbook for deploying the Control Plane required for
a User Provided Infrastructure installation.

Implements https://jira.coreos.com/browse/OSASINFRA-787
@pierreprinetti
Remove unneeded allowed IPs
ca8d3b3 
ref: #2681
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

@tomassedovic
I have addressed your comments. thank you very much for your review. Please take a look!

@pierreprinetti
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt ca8d3b3 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 ca8d3b3 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c82a585 into openshift:master Dec 3, 2019
@pierreprinetti pierreprinetti deleted the os_upi_ansible_master branch December 3, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomassedovic tomassedovic tomassedovic requested changes

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@iamemilio iamemilio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pierreprinetti @iamemilio @openshift-ci-robot @tomassedovic @openshift-merge-robot