Bug 1797638: baremetal: Changes needed for IPv6 #2727
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
/label platform/baremetal |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1340/ |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| IPTABLES=iptables | ||
| IP=$(ip r | grep $PROVISIONING_NIC | awk '/default/ {print $3};') | ||
| if ! ping -c 1 $IP ; then | ||
| IP="[$(ip -6 r | grep $PROVISIONING_NIC | awk '/default/ {print $3};')]" |
There was a problem hiding this comment.
Just a comment, this doesn't work for me, as i don't seem to have any ipv6 default route (even if i enabled router advertisements). However, it worked with an alternative command: /sbin/ip -6 addr show provisioning | grep inet6 | awk -F '[ \t]+|/' '{print $3}' | grep -v ^::1 | grep -v ^fe80
There was a problem hiding this comment.
thanks, will update
openshift-ci-robot
added
size/XL
|
#2895 has been merged so you should be able to rebase now |
pkg/tfvars/baremetal/baremetal.go
Outdated
| driverInfo["deploy_kernel"] = fmt.Sprintf("http://%s/images/ironic-python-agent.kernel", bootstrapProvisioningIP) | ||
| driverInfo["deploy_ramdisk"] = fmt.Sprintf("http://%s/images/ironic-python-agent.initramfs", bootstrapProvisioningIP) | ||
| driverInfo["deploy_kernel"] = fmt.Sprintf("http://%s/images/ironic-python-agent.kernel", wrapIPv6(bootstrapProvisioningIP)) | ||
| driverInfo["deploy_ramdisk"] = fmt.Sprintf("http://%s/images/ironic-python-agent.initramfs", wrapIPv6(bootstrapProvisioningIP)) |
There was a problem hiding this comment.
#2916 includes these fixes, it should land soon
|
@derekhiggins Could you rebase this PR? |
openshift-ci-robot
added
size/M
derekhiggins
force-pushed
the
ipv6
branch
2 times, most recently
from
07daa02
to
09d509d
Compare
|
/retest |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1478/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1484/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1485/ |
|
Sorry for delay, baremetal IPI deploys have been broken due to a couple of issues. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| # be the same host, if none is found then the downloader containers just skip and download | ||
| # from the internet location ( IP=n.n.n.n:nn or [x:x::x]:nn ) | ||
| IP=$(echo $RHCOS_BOOT_IMAGE_URL | sed -e 's/.*:\/\/\([^/]*\)\/.*/\1/g' ) | ||
| CACHEURL="http://$IP/images" |
There was a problem hiding this comment.
Since openshift/ironic-rhcos-downloader#24 this is no longer used, but I guess we can remove that in a follow-up PR
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1489/ |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@derekhiggins: All pull requests linked via external trackers have merged. Bugzilla bug 1797638 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@derekhiggins: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.3 |
|
@stbenjam: new pull request created: #3097 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add support for provisioing over IPv6