Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: add new vCPU limit to docs #2768

Merged
merged 1 commit into from Dec 19, 2019

Conversation

sapkra
Copy link
Contributor

@sapkra sapkra commented Dec 7, 2019

AWS recently changed the instance limit to a vCPU limit

Fixes #2736

@openshift-ci-robot
Copy link
Contributor

Hi @sapkra. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2019
@sapkra
Copy link
Contributor Author

sapkra commented Dec 10, 2019

/assign @sdodson

@sdodson
Copy link
Member

sdodson commented Dec 10, 2019

/cc @kalexand-rh

@sdodson
Copy link
Member

sdodson commented Dec 10, 2019

/lgtm

BTW, according to this article AWS switched to vCPU limits for all accounts on October 24th, so it seems correct to replace instance limit documentation with vCPU limits across the board.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2019
@abhinavdahiya
Copy link
Contributor

/retest

AWS recently changed the instance limit to a vCPU limit

Fixes openshift#2736
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 19, 2019
@sapkra
Copy link
Contributor Author

sapkra commented Dec 19, 2019

I rebased the branch on the current master.

@sdodson
Copy link
Member

sdodson commented Dec 19, 2019

Unless there's a conflict there's generally no need to rebase.
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@sapkra: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 73026e5 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Dec 19, 2019

/override ci/prow/e2e-aws-scaleup-rhel7
/override ci/prow/e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-scaleup-rhel7, ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-scaleup-rhel7
/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2905194 into openshift:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS: Add new default vCPU limit to docs
5 participants