New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include NFS configuration and control plane schedulability. #2772
Conversation
/assign @crawford |
docs/user/zvm/install_upi.md
Outdated
metadata: | ||
annotations: | ||
pv.kubernetes.io/bound-by-controller: "yes" | ||
creationTimestamp: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field shouldn't be required.
docs/user/zvm/install_upi.md
Outdated
finalizers: | ||
- kubernetes.io/pv-protection | ||
name: pv0001 | ||
selfLink: /api/v1/persistentvolumes/pv0001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this field is not required.. we can drop this.
@adambkaplan Do you want any sort of qualifying statements around NFS storage suitability for Image Registry? |
This is a docs change. End-to-end testing is not needed. /override ci/prow/e2e-aws-fips |
@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-aws-fips, ci/prow/e2e-aws-scaleup-rhel7, ci/prow/e2e-aws-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, dbenoit17, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.