Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include NFS configuration and control plane schedulability. #2772

Merged
merged 1 commit into from Dec 9, 2019

Conversation

dbenoit17
Copy link
Contributor

No description provided.

@dbenoit17
Copy link
Contributor Author

/assign @crawford

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2019
docs/user/zvm/install_upi.md Outdated Show resolved Hide resolved
docs/user/zvm/install_upi.md Outdated Show resolved Hide resolved
docs/user/zvm/install_upi.md Outdated Show resolved Hide resolved
metadata:
annotations:
pv.kubernetes.io/bound-by-controller: "yes"
creationTimestamp: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field shouldn't be required.

finalizers:
- kubernetes.io/pv-protection
name: pv0001
selfLink: /api/v1/persistentvolumes/pv0001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this field is not required.. we can drop this.

@sdodson
Copy link
Member

sdodson commented Dec 9, 2019

@adambkaplan Do you want any sort of qualifying statements around NFS storage suitability for Image Registry?

@crawford
Copy link
Contributor

crawford commented Dec 9, 2019

This is a docs change. End-to-end testing is not needed.

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-aws-scaleup-rhel7
/override ci/prow/e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-aws-fips, ci/prow/e2e-aws-scaleup-rhel7, ci/prow/e2e-aws-upgrade

In response to this:

This is a docs change. End-to-end testing is not needed.

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-aws-scaleup-rhel7
/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2019
@sdodson
Copy link
Member

sdodson commented Dec 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, dbenoit17, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a42419d into openshift:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants