New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform/plugins: update libvirt provider #2786
terraform/plugins: update libvirt provider #2786
Conversation
This pulls in some upstream changes [1] that add support for providing Ignition configs to s390x guests. This doesn't require any changes to the Terraform templates, but it does require Ignition to be run with `--provider=openstack` on s390x (there is no support for the QEMU firmware configuration device on s390x, so the OpenStack config-drive is used instead). [1]: dmacvicar/terraform-provider-libvirt#678
The bump looks okay to me. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-4.3 |
@crawford: new pull request created: #2803 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.2 |
@crawford: #2786 failed to apply on top of branch "release-4.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pulls in some upstream changes 1 that add support for providing
Ignition configs to s390x guests. This doesn't require any changes to
the Terraform templates, but it does require Ignition to be run with
--provider=openstack
on s390x (there is no support for the QEMUfirmware configuration device on s390x, so the OpenStack config-drive is
used instead).