Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding terraform for vSphere IPI; changes to tfvars to support it #2841

Merged
merged 2 commits into from Jan 14, 2020
Merged

Adding terraform for vSphere IPI; changes to tfvars to support it #2841

merged 2 commits into from Jan 14, 2020

Conversation

jcpowermac
Copy link
Contributor

This change adds the terraform to create bootstrap and control plane nodes for vSphere IPI.
Adds vSphere tfvars.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2019
@jcpowermac jcpowermac changed the title Adding terraform for vSphere IPI; changes to tfvars to support it [wip] Adding terraform for vSphere IPI; changes to tfvars to support it Dec 18, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2019
@jcpowermac
Copy link
Contributor Author

Terraform needs to be tested
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2019
@jcpowermac
Copy link
Contributor Author

@dav1x @mtnbikenc can you guys take an initial look

dav1x
dav1x reviewed Dec 18, 2019
View reviewed changes
data/data/vsphere/bootstrap/main.tf Show resolved Hide resolved
data/data/vsphere/master/ignition.tf Show resolved Hide resolved
data/data/vsphere/master/ignition.tf Show resolved Hide resolved
data/data/vsphere/main.tf Show resolved Hide resolved
data/data/vsphere/main.tf Show resolved Hide resolved
abhinavdahiya
abhinavdahiya reviewed Dec 19, 2019
View reviewed changes
data/data/vsphere/master/ignition.tf
ignition_encoded = "data:text/plain;charset=utf-8;base64,${base64encode(var.ignition)}"
}

data "ignition_file" "hostname" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the machine-api is to recreate the machine, how will it recreate this behavior?

enxebre
enxebre reviewed Jan 2, 2020
View reviewed changes
data/data/vsphere/master/ignition.tf

data "ignition_file" "hostname" {
count = var.instance_count

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need static ignition config here? post cluster creation we should be able to create a valid master instance via API by relying only on the ignition config served by the mco (machine config operator).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enxebre not sure how else we would set the hostname of the control plane nodes which is required for "baremetal networking" which we are using with vSphere IPI.
https://github.com/openshift/enhancements/pull/148/files#diff-141f756d80782cc4aa106f6b3d264f2dR208

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the template's linux-costomization-options to set hostname?
https://www.terraform.io/docs/providers/vsphere/r/virtual_machine.html#linux-customization-options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstuever that would certainly make it easier. Looks like it requires perl.
https://docs.vmware.com/en/VMware-vSphere/6.7/com.vmware.vsphere.vm_admin.doc/GUID-E63B6FAA-8D35-428D-B40C-744769845906.html#GUID-E63B6FAA-8D35-428D-B40C-744769845906

KB article regarding CoreOS specifically says:
"Guest Customization of CoreOS from vCenter or vCloud Director is not supported."
https://kb.vmware.com/s/article/2109161

Not surpising the guest guide doesn't mention RHCOS:
https://www.vmware.com/resources/compatibility/pdf/VMware_GOS_Compatibility_Guide.pdf

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a shame... I was hoping maybe it was using DHCP trickery.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the host look itself via mDNS and set its hostname that way? This certainly seems like a tricky problem to solve. I'm inclined to suggest we move forward but make sure to track this as something we must figure out

I don't know how close we are to realistically being able to replace control plane hosts today outside of this specific concern. @enxebre do you know?

@jcpowermac jcpowermac changed the title [wip] Adding terraform for vSphere IPI; changes to tfvars to support it Adding terraform for vSphere IPI; changes to tfvars to support it Jan 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2020
@jcpowermac
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@jcpowermac
Copy link
Contributor Author

This PR: #2861
needs to be merged first.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2020
@sdodson
Copy link
Member

sdodson commented Jan 13, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2020
@sdodson
Copy link
Member

sdodson commented Jan 13, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2020
@jcpowermac
Adding terraform for vSphere IPI; changes to tfvars to support it
60e6212 
Added tags to vSphere vCenter objects that will
need to be destroyed.
Removed the ability to create a resource pool.  Using the cluster
default RP inplace.  The customer can move the machines
to a properly configured RP if so desired.
@jcpowermac
Add vsphereprovider api from machine-api-operator
0ddfb8b
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 13, 2020
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 0ddfb8b link /test e2e-libvirt
ci/prow/e2e-openstack 0ddfb8b link /test e2e-openstack
ci/prow/e2e-aws-fips 0ddfb8b link /test e2e-aws-fips
ci/prow/e2e-aws-scaleup-rhel7 0ddfb8b link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@patrickdillon
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot merged commit 91d6918 into openshift:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson sdodson left review comments

@enxebre enxebre enxebre left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@dav1x dav1x dav1x left review comments

@jstuever jstuever jstuever left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@wking wking

@patrickdillon patrickdillon

@mtnbikenc mtnbikenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet