Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack UPI: introduce common playbook #2867

Merged
merged 1 commit into from Dec 24, 2019

Conversation

mandre
Copy link
Member

@mandre mandre commented Dec 23, 2019

The common playbook reads the infraID from metadata.json and computes
the resource names needed by other playbooks.

The common playbook reads the infraID from metadata.json and computes
the resource names needed by other playbooks.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 23, 2019
@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/approve
/label platform/openstack

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 24, 2019

@mandre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 313c468 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7adad93 into openshift:master Dec 24, 2019
@pierreprinetti pierreprinetti deleted the os-upi-common branch December 24, 2019 11:00
@pierreprinetti pierreprinetti restored the os-upi-common branch December 24, 2019 11:01
@mandre mandre deleted the os-upi-common branch April 15, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants