Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1789746: Ensure enough number of retries for cluster with Kuryr SDN #2899

Merged
merged 1 commit into from Jan 13, 2020

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Jan 10, 2020

When using Kuryr SDN the number of resources created on the
OpenStack side is way larger than for the OpenShift SDN case.
For this reason, as there is no specific order for the resources
to be deleted, the chances of the deletion of one resource (e.g.,
a network) being blocked by the deletion of another (e.g. a port
on that network) are higher, thus needed more retries.

When using Kuryr SDN the number of resources created on the
OpenStack side is way larger than for the OpenShift SDN case.
For this reason, as there is no specific order for the resources
to be deleted, the chances of the deletion of one resource (e.g.,
a network) being blocked by the deletion of another (e.g. a port
on that network) are higher, thus needed more retries.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 10, 2020

/assign @mandre

@luis5tb luis5tb changed the title Ensure enough number of retries for cluster with Kuryr SDN Bug 1789746: Ensure enough number of retries for cluster with Kuryr SDN Jan 10, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: This pull request references Bugzilla bug 1789746, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1789746: Ensure enough number of retries for cluster with Kuryr SDN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 10, 2020
@mandre
Copy link
Member

mandre commented Jan 10, 2020

/approve
Thanks for the patch!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 10, 2020

/test e2e-libvirt

@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 10, 2020

/retest

1 similar comment
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 10, 2020

/retest

@jstuever
Copy link
Contributor

/uncc @jstuever
/cc @tomassedovic
I think it looks good, but I'll defer to OpenStack reviewers.

@openshift-ci-robot openshift-ci-robot requested review from tomassedovic and removed request for jstuever January 10, 2020 23:37
@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 13, 2020

/retest

@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 13, 2020

If I got the math right, that's almost 10 hours?

woops, I got the math wrong :) that should be a bit over 2 hours, which I guess is acceptable even for the CI.

👍

@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@pierreprinetti
Copy link
Member

/test e2e-libvirt

@pierreprinetti
Copy link
Member

pierreprinetti commented Jan 13, 2020

/hold

Feel free to /hold cancel once tests are green (e2e-openstack, which should be the only affected suite, is green).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2020
@pierreprinetti
Copy link
Member

/test e2e-libvirt

@mandre
Copy link
Member

mandre commented Jan 13, 2020

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 086545e into openshift:master Jan 13, 2020
@openshift-ci-robot
Copy link
Contributor

@luis5tb: All pull requests linked via external trackers have merged. Bugzilla bug 1789746 has been moved to the MODIFIED state.

In response to this:

Bug 1789746: Ensure enough number of retries for cluster with Kuryr SDN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2020

@luis5tb: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 9fe0312 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@luis5tb
Copy link
Contributor Author

luis5tb commented Jan 13, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@luis5tb: new pull request created: #2903

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants