-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Glide update, droppping tectonic-node-controller and trimming cluster-api #291
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… cluster-api Generated with: $ glide update --strip-vendor $ glide-vc --use-lock-file --no-tests --only-code $ bazel run //:gazelle using: $ glide --version (cd $GOPATH/src/github.com/Masterminds/glide && git describe) v0.13.1-7-g3e13fd1 $ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe) v0.1.0-2-g6ddf6ee $ bazel version Build label: 0.16.1- (@non-git) Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Mon Aug 13 16:42:29 2018 (1534178549) Build timestamp: 1534178549 Build timestamp as int: 1534178549 The tectonic-node-controller removal catches us up with 596591b (.*: replace tectonic node controller with machine config operator, 2018-09-10, openshift#232). The cluster-api trim adjusts the content from b00e40e (vendor: Add client from sigs.k8s.io/cluster-api, 2018-09-04, openshift#119). Because cluster-api wasn't in glide.lock, I suspect neither glide nor glide-vc were run before that commit.
The smoke tests timed out waiting for the router:
/retest |
@wking https://github.com/openshift/installer/pull/287/commits was already doing that. ?? |
Somehow I missed #287 being filed. I'm fine with this getting in however, either this way or through #287. |
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixed in #287. I see the competition for "Most Lines Deleted" is heating up! 😛 /close |
@crawford: Closing this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Generated with:
using:
The tectonic-node-controller removal catches us up with 596591b (#232).
The cluster-api trim adjusts the content from b00e40e (#119). Because cluster-api wasn't in
glide.lock
, I suspect neitherglide
norglide-vc
were run before that commit.