Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Glide update, droppping tectonic-node-controller and trimming cluster-api #291

Closed
wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Sep 20, 2018

Generated with:

$ glide update --strip-vendor
$ glide-vc --use-lock-file --no-tests --only-code
$ bazel run //:gazelle

using:

$ glide --version
(cd $GOPATH/src/github.com/Masterminds/glide && git describe)
v0.13.1-7-g3e13fd1
$ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe)
v0.1.0-2-g6ddf6ee
$ bazel version
Build label: 0.16.1- (@non-git)
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Mon Aug 13 16:42:29 2018 (1534178549)
Build timestamp: 1534178549
Build timestamp as int: 1534178549

The tectonic-node-controller removal catches us up with 596591b (#232).

The cluster-api trim adjusts the content from b00e40e (#119). Because cluster-api wasn't in glide.lock, I suspect neither glide nor glide-vc were run before that commit.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 20, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2018
… cluster-api

Generated with:

  $ glide update --strip-vendor
  $ glide-vc --use-lock-file --no-tests --only-code
  $ bazel run //:gazelle

using:

  $ glide --version
  (cd $GOPATH/src/github.com/Masterminds/glide && git describe)
  v0.13.1-7-g3e13fd1
  $ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe)
  v0.1.0-2-g6ddf6ee
  $ bazel version
  Build label: 0.16.1- (@non-git)
  Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
  Build time: Mon Aug 13 16:42:29 2018 (1534178549)
  Build timestamp: 1534178549
  Build timestamp as int: 1534178549

The tectonic-node-controller removal catches us up with 596591b (.*:
replace tectonic node controller with machine config operator,
2018-09-10, openshift#232).

The cluster-api trim adjusts the content from b00e40e (vendor: Add
client from sigs.k8s.io/cluster-api, 2018-09-04, openshift#119).  Because
cluster-api wasn't in glide.lock, I suspect neither glide nor glide-vc
were run before that commit.
@wking wking changed the title vendor: Glide ipdate, droppping tectonic-node-controller and trimming cluster-api vendor: Glide update, droppping tectonic-node-controller and trimming cluster-api Sep 20, 2018
@wking
Copy link
Member Author

wking commented Sep 20, 2018

The smoke tests timed out waiting for the router:

Waiting for router to be created ...
NAME                          STATUS    ROLES       AGE       VERSION
ip-10-0-14-141.ec2.internal   Ready     bootstrap   4m        v1.11.0+d4cacc0
ip-10-0-16-85.ec2.internal    Ready     master      4m        v1.11.0+d4cacc0
ip-10-0-32-255.ec2.internal   Ready     master      4m        v1.11.0+d4cacc0
ip-10-0-5-115.ec2.internal    Ready     master      4m        v1.11.0+d4cacc0
NAME      DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
router    1         1         1            0           7s
error: timed out waiting for the condition
Installation failed

/retest

@abhinavdahiya
Copy link
Contributor

@wking https://github.com/openshift/installer/pull/287/commits was already doing that. ??
cc @crawford

@wking
Copy link
Member Author

wking commented Sep 20, 2018

https://github.com/openshift/installer/pull/287/commits was already doing that.

Somehow I missed #287 being filed. I'm fine with this getting in however, either this way or through #287.

@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-smoke cbbe745 link /test e2e-aws-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford
Copy link
Contributor

Fixed in #287. I see the competition for "Most Lines Deleted" is heating up! 😛

/close

@openshift-ci-robot
Copy link
Contributor

@crawford: Closing this PR.

In response to this:

Fixed in #287. I see the competition for "Most Lines Deleted" is heating up! 😛

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the glide-update branch September 21, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants