Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Add support to user provided subnet pool #2925

Merged
merged 1 commit into from Jan 22, 2020
Merged

OpenStack: Add support to user provided subnet pool #2925

merged 1 commit into from Jan 22, 2020

Conversation

MaysaMacedo
Copy link
Contributor

Update UPI playbook to account for user provided subnet pool
for pods when Kuryr SDN is used.

Depends on: #2746

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2020
@MaysaMacedo
Copy link
Contributor Author

/label platform/openstack

@MaysaMacedo MaysaMacedo changed the title OpenStack: Add support to user provided subnet pool WIP: OpenStack: Add support to user provided subnet pool Jan 15, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2020
@MaysaMacedo MaysaMacedo force-pushed the ensure-subnet-pool branch 2 times, most recently from 148f7a8 to 5b405ba Compare January 15, 2020 16:53
@MaysaMacedo MaysaMacedo changed the title WIP: OpenStack: Add support to user provided subnet pool OpenStack: Add support to user provided subnet pool Jan 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2020
@MaysaMacedo
Copy link
Contributor Author

/retest

1 similar comment
@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Jan 16, 2020 •
edited

/assign @pierreprinetti

/cc @luis5tb @dulek

@MaysaMacedo
Copy link
Contributor Author

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Jan 16, 2020

other than the failing CI, lgtm!

@MaysaMacedo
Copy link
Contributor Author

/retest

3 similar comments
@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/test all

@MaysaMacedo
Copy link
Contributor Author

/retest

5 similar comments
@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@pierreprinetti
Copy link
Member

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@MaysaMacedo
Copy link
Contributor Author

/retest

@pierreprinetti
Copy link
Member

/approve

Thanks!

@pierreprinetti
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@MaysaMacedo
Copy link
Contributor Author

/retest

@dulek
Copy link
Contributor

dulek commented Jan 21, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@luis5tb
Copy link
Contributor

luis5tb commented Jan 21, 2020

/lgtm

@MaysaMacedo
Copy link
Contributor Author

/test e2e-libvirt

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 21, 2020
@MaysaMacedo
OpenStack: Add support to user provided subnet pool
596343d 
Update UPI playbook to account for user provided subnet pool
for pods when Kuryr SDN is used.
@dulek
Copy link
Contributor

dulek commented Jan 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@dulek
Copy link
Contributor

dulek commented Jan 22, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1f124d6 into openshift:master Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020 •
edited

@MaysaMacedo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 596343d link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti left review comments

@luis5tb luis5tb luis5tb left review comments

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@dulek dulek

@pierreprinetti pierreprinetti

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MaysaMacedo @luis5tb @pierreprinetti @openshift-ci-robot @dulek @openshift-bot @openshift-merge-robot