New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baremetal: Generate CR to configure baremetal. #2958
Conversation
/cc @sadasu Can you have a look at this? Any chance we could get a dev-scripts PR put together that pulls down this PR and MAO (openshift/machine-api-operator#470) and tests them together, without the configmap hacks? |
Use a template to generate the baremetal config CR for use by the MAO and the baremetal operator.
/label platform/baremetal |
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1437/ |
/lgtm |
/retest |
/assign @sdodson This is part of the implementation for openshift/enhancements#119. The CRD was added to the MAO in openshift/machine-api-operator#460. We now need the installer to write out a CR with values from our installation configuration. Currently, MAO reads this by a manually created config map, the goal here is to remove that entirely. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws-upgrade |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@imain: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Use a template to generate the baremetal config CR for use by the MAO
and the baremetal operator.