Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump RHCOS to 44.81.202001241932.0 #2986

Merged
merged 1 commit into from Jan 27, 2020
Merged

Bump RHCOS to 44.81.202001241932.0 #2986

merged 1 commit into from Jan 27, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jan 24, 2020 

./hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.4/44.81.202001241932.0/x86_64/meta.json amd64

Notably, this includes a fix for IPv6 single-stack:
https://bugzilla.redhat.com/show_bug.cgi?id=1787620
https://bugzilla.redhat.com/show_bug.cgi?id=1793591

$ ./differ.py --first-endpoint art --first-version 44.81.202001240222.0 --second-endpoint art
 --second-version 44.81.202001241932.0
{
    "sources": {
        "44.81.202001240222.0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.4/44.81.202001240222.0/x86_64/commitmeta.json",
        "44.81.202001241932.0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.4/44.81.202001241932.0/x86_64/commitmeta.json"
    },
    "diff": {
        "dracut": {
            "44.81.202001240222.0": "dracut-049-63.git20200114.el8.x86_64",
            "44.81.202001241932.0": "dracut-049-64.git20200123.el8.x86_64"
        },
        "dracut-network": {
            "44.81.202001240222.0": "dracut-network-049-63.git20200114.el8.x86_64",
            "44.81.202001241932.0": "dracut-network-049-64.git20200123.el8.x86_64"
        },
        "machine-config-daemon": {
            "44.81.202001240222.0": "machine-config-daemon-4.4.0-202001232316.git.1.2405544.el8.x86_64",
            "44.81.202001241932.0": "machine-config-daemon-4.4.0-202001241616.git.1.3a866d3.el8.x86_64"
        },
        "openshift-clients": {
            "44.81.202001240222.0": "openshift-clients-4.4.0-202001222020.git.1.0b968f5.el8.x86_64",
            "44.81.202001241932.0": "openshift-clients-4.4.0-202001240656.git.1.db0174c.el8.x86_64"
        },
        "openshift-hyperkube": {
            "44.81.202001240222.0": "openshift-hyperkube-4.4.0-202001232117.git.0.03df719.el8.x86_64",
            "44.81.202001241932.0": "openshift-hyperkube-4.4.0-202001241232.git.0.e552f5f.el8.x86_64"
        }
    }
}

@jlebon
Bump RHCOS to 44.81.202001241932.0
b989e2f 
```
./hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.4/44.81.202001241932.0/x86_64/meta.json amd64
```

Notably, this includes a fix for IPv6 single-stack:
https://bugzilla.redhat.com/show_bug.cgi?id=1787620
https://bugzilla.redhat.com/show_bug.cgi?id=1793591

```
$ ./differ.py --first-endpoint art --first-version 44.81.202001240222.0 --second-endpoint art
 --second-version 44.81.202001241932.0
{
    "sources": {
        "44.81.202001240222.0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.4/44.81.202001240222.0/x86_64/commitmeta.json",
        "44.81.202001241932.0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.4/44.81.202001241932.0/x86_64/commitmeta.json"
    },
    "diff": {
        "dracut": {
            "44.81.202001240222.0": "dracut-049-63.git20200114.el8.x86_64",
            "44.81.202001241932.0": "dracut-049-64.git20200123.el8.x86_64"
        },
        "dracut-network": {
            "44.81.202001240222.0": "dracut-network-049-63.git20200114.el8.x86_64",
            "44.81.202001241932.0": "dracut-network-049-64.git20200123.el8.x86_64"
        },
        "machine-config-daemon": {
            "44.81.202001240222.0": "machine-config-daemon-4.4.0-202001232316.git.1.2405544.el8.x86_64",
            "44.81.202001241932.0": "machine-config-daemon-4.4.0-202001241616.git.1.3a866d3.el8.x86_64"
        },
        "openshift-clients": {
            "44.81.202001240222.0": "openshift-clients-4.4.0-202001222020.git.1.0b968f5.el8.x86_64",
            "44.81.202001241932.0": "openshift-clients-4.4.0-202001240656.git.1.db0174c.el8.x86_64"
        },
        "openshift-hyperkube": {
            "44.81.202001240222.0": "openshift-hyperkube-4.4.0-202001232117.git.0.03df719.el8.x86_64",
            "44.81.202001241932.0": "openshift-hyperkube-4.4.0-202001241232.git.0.e552f5f.el8.x86_64"
        }
    }
}
```
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2020
@jlebon
Copy link
Member Author

jlebon commented Jan 24, 2020 •
edited

Sorry, I realize RHCOS was just bumped. Though things weren't quite ready yet.

cgwalters
cgwalters approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ashcrow
Copy link
Member

ashcrow commented Jan 25, 2020

/retest

3 similar comments
@ashcrow
Copy link
Member

ashcrow commented Jan 25, 2020

/retest

@ashcrow
Copy link
Member

ashcrow commented Jan 25, 2020

/retest

@miabbott
Copy link
Member

/retest

@sdodson
Copy link
Member

sdodson commented Jan 27, 2020

/test e2e-metal

@sdodson
Copy link
Member

sdodson commented Jan 27, 2020

/lgtm
/hold
I don't want to block on e2e tests from e2e-metal passing but do want to see that the cluster at least installs. Clear the hold if you can confirm such.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@sdodson
Copy link
Member

sdodson commented Jan 27, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@sdodson
Copy link
Member

sdodson commented Jan 27, 2020

2020/01/27 14:37:06 Container setup in pod e2e-metal completed successfully
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c1cd354 into openshift:master Jan 27, 2020
@openshift-ci-robot
Copy link
Contributor

@jlebon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt b989e2f link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 b989e2f link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-metal b989e2f link /test e2e-metal

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yuqi-zhang added a commit to yuqi-zhang/installer that referenced this pull request Jan 27, 2020
@yuqi-zhang
RHCOS: revert to 44.81.202001241431.0
41ed5e7 
In openshift#2986 we updated RHCOS
to 44.81.202001241932.0, which happened to carry a COSA change
coreos/coreos-assembler@1dc3cdd
which broke GCP metadata. Since we didn't run e2e-gcp on that 2986,
we didn't catch this. This seems to have broken GCP CI since it is
unable to find the tarball being referenced in the meta.

This temporarily reverts RHCOS to one version previous, which includes
the IPV6 changes but doesn't have the GCP break. This should fix GCP
for now as we fix COSA.

In the future we should probably have each RHCOS bump go through
all the platforms.

Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
@yuqi-zhang yuqi-zhang mentioned this pull request Jan 27, 2020
Merged
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Jan 30, 2020
@yuqi-zhang @jhixson74
RHCOS: revert to 44.81.202001241431.0
d4bb717 
In openshift#2986 we updated RHCOS
to 44.81.202001241932.0, which happened to carry a COSA change
coreos/coreos-assembler@1dc3cdd
which broke GCP metadata. Since we didn't run e2e-gcp on that 2986,
we didn't catch this. This seems to have broken GCP CI since it is
unable to find the tarball being referenced in the meta.

This temporarily reverts RHCOS to one version previous, which includes
the IPV6 changes but doesn't have the GCP break. This should fix GCP
for now as we fix COSA.

In the future we should probably have each RHCOS bump go through
all the platforms.

Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@cgwalters cgwalters cgwalters approved these changes

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@sdodson sdodson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jlebon @ashcrow @miabbott @sdodson @openshift-ci-robot @openshift-bot @cgwalters @openshift-merge-robot