Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1796322: [release-4.4] docs: Docs for setting kernelType during initial cluster install #2992

Merged
merged 1 commit into from Feb 4, 2020

Conversation

sinnykumari
Copy link
Contributor

Document how to switch from traditional to realtime kernel
on RHCOS node

Signed-off-by: Sinny Kumari sinny@redhat.com

@sinnykumari
Copy link
Contributor Author

cc @runcom @cgwalters

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2020
docs/user/customization.md Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
@runcom
Copy link
Member

runcom commented Jan 28, 2020

/lgtm
/approve

(I may not have rights but still)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@sinnykumari
Copy link
Contributor Author

/retest

2 similar comments
@runcom
Copy link
Member

runcom commented Jan 28, 2020

/retest

@sinnykumari
Copy link
Contributor Author

/retest

@runcom
Copy link
Member

runcom commented Jan 29, 2020

@abhinavdahiya ptal

@runcom
Copy link
Member

runcom commented Jan 29, 2020

/retest

@sinnykumari
Copy link
Contributor Author

/test e2e-aws-scaleup-rhel7

@abhinavdahiya
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

docs/user/customization.md Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2020
docs/user/customization.md Outdated Show resolved Hide resolved
docs/user/customization.md Outdated Show resolved Hide resolved
@wking
Copy link
Member

wking commented Jan 30, 2020

Also needs a bug or a delay until the 4.4/4.5 split now that openshift/release#6912 has tightened master requirements.

Document how to switch from traditional to realtime kernel
on RHCOS node

Signed-off-by: Sinny Kumari <sinny@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@sinnykumari
Copy link
Contributor Author

/retitle Bug 1796322: [release-4.4] docs: Docs for setting kernelType during initial cluster install

@openshift-ci-robot openshift-ci-robot changed the title docs: Docs for setting kernelType during initial cluster install Bug 1796322: [release-4.4] docs: Docs for setting kernelType during initial cluster install Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Bugzilla bug 1796322, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1796322: [release-4.4] docs: Docs for setting kernelType during initial cluster install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 30, 2020
@sinnykumari
Copy link
Contributor Author

/retest

1 similar comment
@sinnykumari
Copy link
Contributor Author

/retest

@sdodson
Copy link
Member

sdodson commented Jan 30, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Bugzilla bug 1796322, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 30, 2020
@sdodson
Copy link
Member

sdodson commented Jan 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@sinnykumari
Copy link
Contributor Author

@wking This PR have valid bug now, I will let you remove hold.

@sdodson
Copy link
Member

sdodson commented Feb 4, 2020

/hold cancel
All feedback looks to have been addressed

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020
@sinnykumari
Copy link
Contributor Author

Thanks @sdodson

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5843ffe into openshift:master Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: All pull requests linked via external trackers have merged. Bugzilla bug 1796322 has been moved to the MODIFIED state.

In response to this:

Bug 1796322: [release-4.4] docs: Docs for setting kernelType during initial cluster install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sinnykumari: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 80ce075 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants