New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update OpenStack documentation #2993
Conversation
Swift is not used to store ignition configs anymore, and not it is an optional component for the image registry.
Glance is required for the installation and this should be documented.
docs/user/openstack/customization.md
Outdated
## Table of Contents | ||
|
||
- [Installation customizations](#installation-customizations) | ||
- [OpenStack Platform Customization](#openStack-platform-customization) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You left an uppercase S
in there, it can't find the anchor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
/approve |
Are we supposed to be exposing the image overrides to the customer? My understanding was that these are not supported, and should not be recommended to customers. |
@iamemilio I did this because the way we use the variable is a little bit unusual and I got a lot of PMs where people ask to explain how this works. So I wanted to have it documented somewhere and give them the link instead of explaining it over and over again. |
Hmm that does seem problematic, however I think I would like alignment from @sdodson before approving this. |
Now this section is located in "known-issues", but logically it should be placed in "troubleshooting".
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@Fedosin: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR updates OpenStack documentation based on recent changes.