Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update OpenStack documentation #2993

Merged
merged 4 commits into from Jan 28, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jan 27, 2020

This PR updates OpenStack documentation based on recent changes.

  1. Updates Swift requirements. Now Swift is not a mandatory service but just an optional backend for image registry.
  2. Adds Glance requirements. Glance is used for storing RHCOS images and bootstrap ignition configs.
  3. Adds RHCOS image customization section for disconnected environments.
  4. Moves "Cluster destruction if its metadata has been lost" section from "known-issues" to "troubleshooting".

Swift is not used to store ignition configs anymore, and not it is
an optional component for the image registry.
Glance is required for the installation and this should be documented.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2020
## Table of Contents

- [Installation customizations](#installation-customizations)
- [OpenStack Platform Customization](#openStack-platform-customization)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left an uppercase S in there, it can't find the anchor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@mandre
Copy link
Member

mandre commented Jan 27, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@iamemilio
Copy link

Are we supposed to be exposing the image overrides to the customer? My understanding was that these are not supported, and should not be recommended to customers.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 27, 2020

@iamemilio I did this because the way we use the variable is a little bit unusual and I got a lot of PMs where people ask to explain how this works. So I wanted to have it documented somewhere and give them the link instead of explaining it over and over again.
Also, you can't install OpenShift on a disconnected environment without setting this variable, so users should be aware of this possibility.

@iamemilio
Copy link

Hmm that does seem problematic, however I think I would like alignment from @sdodson before approving this.

Now this section is located in "known-issues", but logically it
should be placed in "troubleshooting".
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@sdodson
Copy link
Member

sdodson commented Jan 27, 2020

/approve
I'm fine with the custom image stuff being in dev docs. Don't know if you wanted to squash any of this down or not.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@iamemilio
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 837a311 into openshift:master Jan 28, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 2f6af25 link /test e2e-aws-fips
ci/prow/e2e-aws-scaleup-rhel7 2f6af25 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants