Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Use correct type to unmarshal clouds #3000

Merged
merged 1 commit into from
Jan 29, 2020
Merged

OpenStack: Use correct type to unmarshal clouds #3000

merged 1 commit into from
Jan 29, 2020

Commits on Jan 28, 2020

  1. OpenStack: Use correct type to unmarshal clouds 

    Now, to unmarshal clouds from yaml files we always use type Clouds
https://github.com/gophercloud/utils/blob/master/openstack/clientconfig/results.go#L10-L15

But this is wrong because for clouds-public.yaml we should use PublicClouds
https://github.com/gophercloud/utils/blob/master/openstack/clientconfig/results.go#L3-L8

otherwise LoadPublicCloudsYAML function always returns an empty map.

Fixes: openshift#2997
    @Fedosin
    Fedosin committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    1b72478 View commit details
    Browse the repository at this point in the history