[fcos] cherrypick UPI fixes #3013
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/retest |
|
/retest |
|
/retest |
vrutkovs
force-pushed
the
fcos-vsphere-jan29
branch
from
6fff234
to
5911e64
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
vrutkovs
force-pushed
the
fcos-vsphere-jan29
branch
from
4b2bb89
to
8496ea2
Compare
|
/retest |
|
/retest |
| @@ -59,17 +59,16 @@ if [ ! -f .pivot-done ]; then | |||
| chmod +x /usr/local/bin/machine-config-daemon | |||
| restorecon /usr/local/bin/machine-config-daemon | |||
|
|
|||
| # Disable zincati | |||
| systemctl disable zincati.service | |||
The bootstrap MCS is responsible for serving Ignition configs to the booting control plane machines while we wait for the full control plane (which will host the in-cluster MCS). If we remove this too early, it will prevent the control plane machines from booting and the control plane from starting. The etcd health check, which is the gate before we remove the MCS, reports healthly (since the one-node, bootstrap etcd cluster is actually up) before the control plane machines had a chance to boot. The result is that one or more of the control plane machines get stuck during boot (because Ignition is still trying to fetch a config) and the cluster fails to bootstrap. This moves the bootstrap MCS removal after bootkube has finished, which will ensure that all of the initial manifests have been loaded into the cluster (including the MCO/MCS manifests).
This adds support for generating the openshift-install ConfigMap when using a UPI installation flow. Before this, the ConfigMap was generated during the "cluster" target rather than the manifests target, so that we could distinguish between an IPI and a UPI installation. The user had the option of overriding the "invoker" field using the environment variable OPENSHIFT_INSTALL_INVOKER. Even if the environment variable was used, the ConfigMap would not be present in a UPI installation (because it wasn't generated in the "manifests" target). This change causes the installer to generate that ConfigMap in the "manifests" target (in addition to the "cluster" target) when it sees the environment variable. We will make use of this functionality in CI, where we specify the job as the invoker.
vrutkovs
force-pushed
the
fcos-vsphere-jan29
branch
from
f40859d
to
9665ec6
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
vSphere bootstrapped but authentication operator got stuck (Route53 issues?): https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/3013/pull-ci-openshift-installer-fcos-e2e-vsphere/399 /retest |
vrutkovs
force-pushed
the
fcos-vsphere-jan29
branch
from
9665ec6
to
ea8a8c8
Compare
vrutkovs
force-pushed
the
fcos-vsphere-jan29
branch
2 times, most recently
from
0e6ede5
to
2407a57
Compare
Make sure all images are pullable before running those. This ensures detached podman containers won't hang is a weird state
vrutkovs
force-pushed
the
fcos-vsphere-jan29
branch
from
2407a57
to
88f4b1c
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sdodson
added
the
bugzilla/valid-bug
|
/lgtm |
|
/override ci/prow/e2e-vsphere |
|
@LorbusChris: LorbusChris unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/override ci/prow/e2e-vsphere |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This should resolve issues on vSphere UPI test.
Bug 1791440: asset/manifests: add openshift-install configmap #3031 and Bug 1795776: data/bootstrap: delay the removal of bootstrap mcs #3007
crunto avoid confusing podmanTODO: do the same on masters / workers