Bug 1795436: update error message when deleting default GCP routes #3049

patrickdillon · 2020-02-03T17:42:01Z

Default routes cannot be manually deleted in GCP, but that doesn't stop us from trying. These attempts result in error messages that look like this:

Failed to delete route {default-route-013b0a83601b2182 default-route-013b0a83601b2182 route }: failed to delete route default-route-013b0a83601b2182: googleapi: Error 400: The local route cannot be deleted., badRequest

These error messages have led some users, especially in CI to mistake these as significant errors. This commit attempts to make the error message look like something a l
ittle more expected:

Failed to delete route default-route-bb10ec00c23c0493: this looks like a default route, which cannot be deleted manually but will be deleted with the corresponding network

Default routes cannot be manually deleted in GCP, but that doesn't stop us from trying. These attempts result in error messages that look like this: DEBUG Failed to delete route {default-route-013b0a83601b2182 default-route-013b0a83601b2182 route }: failed to delete route default-route-013b0a83601b2182: googleapi: Error 400: The local route cannot be deleted., badRequest These error messages have led some users, especially in CI to mistake these as significant errors. This commit attempts to make the error message look like something a l ittle more expected: level=debug msg="Failed to delete route default-route-bb10ec00c23c0493: this looks like a default route, which cannot be deleted manually but will be deleted with the corresponding network"

openshift-ci-robot · 2020-02-03T17:42:07Z

@patrickdillon: This pull request references Bugzilla bug 1795436, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1795436: update error message when deleting default GCP routes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2020-02-03T17:43:00Z

cc @jstuever

jstuever · 2020-02-03T19:21:42Z

Might be better to not even attempt to delete the default routes? They are picked up in the network-destroy bits[1]. Could probably just modify the filter[2] to exclude them.

https://github.com/openshift/installer/blob/master/pkg/destroy/gcp/network.go#L78
https://github.com/openshift/installer/blob/master/pkg/destroy/gcp/route.go#L12

abhinavdahiya · 2020-02-03T21:41:16Z

Might be better to not even attempt to delete the default routes? They are picked up in the network-destroy bits[1]. Could probably just modify the filter[2] to exclude them.

https://github.com/openshift/installer/blob/master/pkg/destroy/gcp/network.go#L78
https://github.com/openshift/installer/blob/master/pkg/destroy/gcp/route.go#L12

what if somebody adds a route prefiexed default-route ?? we would skip the deletion for it and loop failing to delete the network?

abhinavdahiya · 2020-02-04T17:12:52Z

pkg/destroy/gcp/route.go

@@ -56,6 +57,9 @@ func (o *ClusterUninstaller) deleteRoute(item cloudResource) error {
 	op, err := o.computeSvc.Routes.Delete(o.ProjectID, item.name).RequestId(o.requestID(item.typeName, item.name)).Context(ctx).Do()
 	if err != nil && !isNoOp(err) {
 		o.resetRequestID(item.typeName, item.name)
+		if strings.HasPrefix(item.name, "default-route") {
+			return errors.New("this looks like a default route, which cannot be deleted manually but will be deleted with the corresponding network")


what about error here

installer/pkg/destroy/gcp/route.go

Lines 65 to 68 in 5ea1f2c

if op != nil && op.Status == "DONE" && isErrorStatus(op.HttpErrorStatusCode) {

o.resetRequestID(item.typeName, item.name)

return errors.Errorf("failed to delete route %s with error: %s", item.name, operationErrorMessage(op))

}

??

Hitting this error would be unexpected, so I don't see a need for special handling as in the first case where we expect to hit the error. Let me know if you disagree.

abhinavdahiya · 2020-02-04T17:13:06Z

/test e2e-gcp

jstuever · 2020-02-04T20:03:10Z

/lgtm

abhinavdahiya · 2020-02-04T23:23:50Z

/approve

/retest

openshift-ci-robot · 2020-02-04T23:24:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/destroy/gcp/OWNERS~~ [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-05T00:29:16Z

/retest