Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1791318: Don't fail on unavailable features on OpenStack. #3063

Merged
merged 1 commit into from Feb 13, 2020

Conversation

gryf
Copy link
Member

@gryf gryf commented Feb 5, 2020

Currently if we are looking for extensions for Neutron or try to list
services, it might happen, that underlying OpenStack cloud doesn't
support listing either extension or services. This patch is fixing it,
and assumption is, that trunk support is disabled in a case of
inability of listing Neutron extensions, and/or octavia support is
disabled in case of inability of listing services, instead of aborting
installation.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2020
@gryf
Copy link
Member Author

gryf commented Feb 5, 2020

/hold

I need to check one more thing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2020
@gryf
Copy link
Member Author

gryf commented Feb 5, 2020

/retest

@gryf gryf changed the title Don't fail on unavailable features on OpenStack. Bug 1791318: Don't fail on unavailable features on OpenStack. Feb 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 6, 2020
@openshift-ci-robot
Copy link
Contributor

@gryf: This pull request references Bugzilla bug 1791318, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1791318: Don't fail on unavailable features on OpenStack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gryf
Copy link
Member Author

gryf commented Feb 6, 2020

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Feb 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Feb 6, 2020

/assign @mandre

@luis5tb
Copy link
Contributor

luis5tb commented Feb 6, 2020

/retest

@mandre
Copy link
Member

mandre commented Feb 6, 2020

/lgtm

@gryf
Copy link
Member Author

gryf commented Feb 6, 2020

/retest

@gryf
Copy link
Member Author

gryf commented Feb 6, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
pkg/types/openstack/validation/platform.go Outdated Show resolved Hide resolved
pkg/types/openstack/validation/platform.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@dulek
Copy link
Contributor

dulek commented Feb 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@gryf
Copy link
Member Author

gryf commented Feb 6, 2020

/retest

2 similar comments
@gryf
Copy link
Member Author

gryf commented Feb 7, 2020

/retest

@gryf
Copy link
Member Author

gryf commented Feb 7, 2020

/retest

Currently if we are looking for extensions for Neutron or try to list
services, it might happen, that underlying OpenStack cloud doesn't
support listing either extension or services. This patch is fixing it,
and assumption is, that trunk support is disabled in a case of
inability of listing Neutron extensions, and/or octavia support is
disabled in case of inability of listing services, instead of aborting
installation.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Feb 10, 2020

/retest

@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@gryf
Copy link
Member Author

gryf commented Feb 10, 2020

/retest

2 similar comments
@gryf
Copy link
Member Author

gryf commented Feb 10, 2020

/retest

@gryf
Copy link
Member Author

gryf commented Feb 11, 2020

/retest

@luis5tb
Copy link
Contributor

luis5tb commented Feb 13, 2020

/assign @mandre

@mandre
Copy link
Member

mandre commented Feb 13, 2020

/lgtm

@mandre
Copy link
Member

mandre commented Feb 13, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Feb 13, 2020

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4a4d46b into openshift:master Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

@gryf: All pull requests linked via external trackers have merged. Bugzilla bug 1791318 has been moved to the MODIFIED state.

In response to this:

Bug 1791318: Don't fail on unavailable features on OpenStack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gryf: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 8ec7103 link /test e2e-openstack
ci/prow/e2e-ovirt 8ec7103 link /test e2e-ovirt
ci/prow/e2e-libvirt 8ec7103 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 8ec7103 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bostrt
Copy link
Contributor

bostrt commented Apr 28, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@bostrt: new pull request created: #3514

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants