New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1797806: asset/manifests: add new installation config map #3065
Bug 1797806: asset/manifests: add new installation config map #3065
Conversation
This is a follow-up for the logic introduced in 27de643. The behavior of the openshift-install ConfigMap is reverted, making it such that the ConfigMap is always injected in an IPI installation, but never it a UPI installation. A new ConfigMap, openshift-install-manifests, is introduced, which is always injected at the manifests target. Both of these ConfigMaps contain the same data: the invoker and the installer version, at the time of their respective creation. This will allow us to continue determining several things: 1. Was the cluster installed via IPI or UPI? 2. What invoked the installer to create the cluster? It will also allow us to determine some new information: 1. Regardless of installation strategy, what invoked the installer to create the manifests? 2. Was the version of the installer used to create the manifests the same as the version that created the cluster (assuming IPI)?
@crawford: This pull request references Bugzilla bug 1797806, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@crawford: All pull requests linked via external trackers have merged. Bugzilla bug 1797806 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@crawford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is a follow-up for the logic introduced in 27de643. The behavior
of the openshift-install ConfigMap is reverted, making it such that the
ConfigMap is always injected in an IPI installation, but never it a UPI
installation. A new ConfigMap, openshift-install-manifests, is
introduced, which is always injected at the manifests target. Both of
these ConfigMaps contain the same data: the invoker and the installer
version, at the time of their respective creation. This will allow us to
continue determining several things:
It will also allow us to determine some new information:
create the manifests?
same as the version that created the cluster (assuming IPI)?