Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install #3120

Merged
merged 1 commit into from May 8, 2020
Merged

Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install #3120

merged 1 commit into from May 8, 2020

Conversation

jhixson74
Copy link
Member

@jhixson74 jhixson74 commented Feb 18, 2020 •
edited

This code checks to see if an existing DNS record exists for api.clusterName and fails if it exists.

See https://bugzilla.redhat.com/show_bug.cgi?id=1732124

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2020
@fabianofranz
Copy link
Member

/hold

needs #2764

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2020
@fabianofranz
Copy link
Member

/retitle Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install

@openshift-ci-robot openshift-ci-robot changed the title Azure: don't allow installing with the same cluster name as an existing install Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install Feb 18, 2020
@openshift-ci-robot
Copy link
Contributor

@jhixson74: This pull request references Bugzilla bug 1732124, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@fabianofranz
Copy link
Member

/lgtm

but it'll probably need it again once the other PR merges and you rebase with it.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@jhixson74
Copy link
Member Author

/lgtm

but it'll probably need it again once the other PR merges and you rebase with it.

I have eliminated the need for the other PR. This works without it now.

@jhixson74
Copy link
Member Author

/test e2e-azure

@jhixson74
Copy link
Member Author

/test e2e-azure

@openshift-ci-robot
Copy link
Contributor

@jhixson74: This pull request references Bugzilla bug 1732124, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/medium labels Apr 29, 2020
@jhixson74
Copy link
Member Author

/test e2e-azure

1 similar comment
@jhixson74
Copy link
Member Author

/test e2e-azure

@jhixson74 jhixson74 force-pushed the master_azure_bz_1732124 branch 4 times, most recently from 0cb98cb to 5803fe0 Compare May 6, 2020 21:45
@jhixson74
Copy link
Member Author

/test e2e-azure

@jhixson74
Azure: don't allow installing with the same cluster name as existing …
ddf3973 
…install

Check for an existing "api.clusterName" CNAME, A, and AAA record. If it exists,
then the install will fail.

See https://bugzilla.redhat.com/show_bug.cgi?id=1732124
@jhixson74
Copy link
Member Author

/test e2e-azure

@abhinavdahiya
Copy link
Contributor

/approve
/lgtm

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 8, 2020 •
edited

@jhixson74: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 06e56f4 link /test e2e-azure
ci/prow/e2e-openstack ddf3973 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 94f6539 into openshift:master May 8, 2020
@openshift-ci-robot
Copy link
Contributor

@jhixson74: All pull requests linked via external trackers have merged: openshift/installer#3120. Bugzilla bug 1732124 has been moved to the MODIFIED state.

In response to this:

Bug 1732124: Azure: don't allow installing with the same cluster name as an existing install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

Assignees

@fabianofranz fabianofranz

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jhixson74 @fabianofranz @openshift-ci-robot @abhinavdahiya @openshift-bot @openshift-merge-robot