Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack UPI: soft-anti-affinity policy for CP #3128

Merged
merged 1 commit into from Feb 27, 2020

Conversation

pierreprinetti
Copy link
Member

This places the Control Plane servers in a Server Group that enforces
"soft anti-affinity" policy.

"Soft anti-affinity" will cause Nova to create VMs on separate hosts, if
that is possible.

Implements OSASINFRA-1015

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2020
This places the Control Plane servers in a Server Group that enforces
"soft anti-affinity" policy.

"Soft anti-affinity" will cause Nova to create VMs on separate hosts, if
that is possible.

Implements OSASINFRA-1015
@pierreprinetti
Copy link
Member Author

/uncc jhixson74 patrickdillon

@pierreprinetti
Copy link
Member Author

/label platform/openstack

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@pierreprinetti
Copy link
Member Author

/retest

2 similar comments
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

(test failures are not relevant)

@tomassedovic
Copy link
Contributor

/lgtm
/hold

I like it, thanks! I've been planning to do a 4.4 UPI run and I'll include this chance to give this a go. But it may take a few days. The change looks perfect to me, I just didn't get to test it yet.

If you've tested this works, feel free to cancel the hold.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 19, 2020
@mandre
Copy link
Member

mandre commented Feb 19, 2020

/lgtm 👍

@tomassedovic
Copy link
Contributor

/hold cancel

I did test this patch locally and had no issues with it.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ce30494 into openshift:master Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 2b6ccf7 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti pierreprinetti deleted the OSASINFRA-1015 branch February 27, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants