New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1766691: go.mod: bump terraform-provider-aws to v2.49.0 #3140
bug 1766691: go.mod: bump terraform-provider-aws to v2.49.0 #3140
Conversation
@abhinavdahiya: This pull request references Bugzilla bug 1766691, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold hmm, the terraform azure provider changes :/ |
``` verifying github.com/openshift/terraform-provider-azurerm@v1.41.1-openshift: checksum mismatch downloaded: h1:5G0U2XoNchxl6VKJJYB6X0RTmDk0mWCoZ9jEt1F0S3I= sum.golang.org: h1:aTLUvsRLkMUJRaJBvO0ZV8ZrtP+sxMhD5vMyhIwNrWE= ``` looks like the proxy and sum db for go modules had different version from actual source due to some force push on the repo.
brings in fix for aws_record timeout [1] and other fixes mentioned in CHANGELOG [2] updated using ``` go get github.com/terraform-providers/terraform-provider-aws@f0f304894df67616dfbd675bc9687a7db266ad41 ``` Using the tag failed with error ``` go get github.com/terraform-providers/terraform-provider-aws@v2.49.0 go: finding github.com/terraform-providers/terraform-provider-aws v2.49.0 go: finding github.com/terraform-providers/terraform-provider-aws v2.49.0 go get github.com/terraform-providers/terraform-provider-aws@v2.49.0: github.com/terraform-providers/terraform-provider-aws@v2.49.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2 ``` Also removes the indirect dependecy on `aws-iam-authenticator` because of [3] [1]: hashicorp/terraform-provider-aws#11895 [2]: https://github.com/terraform-providers/terraform-provider-aws/blob/v2.49.0/CHANGELOG.md#2490-february-14-2020 [3]: hashicorp/terraform-provider-aws#11822
fd8439c
to
51784a3
Compare
/hold cancel |
/test e2e-gcp |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@abhinavdahiya: All pull requests linked via external trackers have merged. Bugzilla bug 1766691 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhinavdahiya: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Brings in fix for aws_record timeout 1 and other fixes mentioned in CHANGELOG 2
updated using
Using the tag failed with error
Also removes the indirect dependecy on
aws-iam-authenticator
because of 3