Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1766691: go.mod: bump terraform-provider-aws to v2.49.0 #3140

Merged
merged 3 commits into from Feb 21, 2020

Conversation

abhinavdahiya
Copy link
Contributor

Brings in fix for aws_record timeout 1 and other fixes mentioned in CHANGELOG 2

updated using

go get github.com/terraform-providers/terraform-provider-aws@f0f304894df67616dfbd675bc9687a7db266ad41

Using the tag failed with error

go get github.com/terraform-providers/terraform-provider-aws@v2.49.0
go: finding github.com/terraform-providers/terraform-provider-aws v2.49.0
go: finding github.com/terraform-providers/terraform-provider-aws v2.49.0
go get github.com/terraform-providers/terraform-provider-aws@v2.49.0: github.com/terraform-providers/terraform-provider-aws@v2.49.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

Also removes the indirect dependecy on aws-iam-authenticator because of 3

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: This pull request references Bugzilla bug 1766691, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bug 1766691: go.mod: bump terraform-provider-aws to v2.49.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 19, 2020
@abhinavdahiya
Copy link
Contributor Author

/hold

hmm, the terraform azure provider changes :/

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2020
```
verifying github.com/openshift/terraform-provider-azurerm@v1.41.1-openshift: checksum mismatch
        downloaded: h1:5G0U2XoNchxl6VKJJYB6X0RTmDk0mWCoZ9jEt1F0S3I=
        sum.golang.org: h1:aTLUvsRLkMUJRaJBvO0ZV8ZrtP+sxMhD5vMyhIwNrWE=
```

looks like the proxy and sum db for go modules had different version from actual source due to some force push on the repo.
brings in fix for aws_record timeout [1] and other fixes mentioned in CHANGELOG [2]

updated using

```
go get github.com/terraform-providers/terraform-provider-aws@f0f304894df67616dfbd675bc9687a7db266ad41
```

Using the tag failed with error
```
go get github.com/terraform-providers/terraform-provider-aws@v2.49.0
go: finding github.com/terraform-providers/terraform-provider-aws v2.49.0
go: finding github.com/terraform-providers/terraform-provider-aws v2.49.0
go get github.com/terraform-providers/terraform-provider-aws@v2.49.0: github.com/terraform-providers/terraform-provider-aws@v2.49.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2
```

Also removes the indirect dependecy on `aws-iam-authenticator` because of [3]

[1]: hashicorp/terraform-provider-aws#11895
[2]: https://github.com/terraform-providers/terraform-provider-aws/blob/v2.49.0/CHANGELOG.md#2490-february-14-2020
[3]: hashicorp/terraform-provider-aws#11822
@abhinavdahiya
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2020
@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp
/test e2e-azure

@abhinavdahiya
Copy link
Contributor Author

/retest

1 similar comment
@abhinavdahiya
Copy link
Contributor Author

/retest

@sdodson
Copy link
Member

sdodson commented Feb 21, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e440bba into openshift:master Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: All pull requests linked via external trackers have merged. Bugzilla bug 1766691 has been moved to the MODIFIED state.

In response to this:

bug 1766691: go.mod: bump terraform-provider-aws to v2.49.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 51784a3 link /test e2e-openstack
ci/prow/e2e-libvirt 51784a3 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 51784a3 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants