Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootkube: use localhost endpoint for kas-o and etcdctl #3148

Closed
wants to merge 1 commit into from

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Feb 20, 2020

Simplifying the selection of the bootstrap etcd instance by using localhost. This work is to fix help Ipv6.

depends on: openshift/cluster-etcd-operator#175

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sdodson
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion changed the title [wip] bootkube: populate BOOTSTRAP_IP from CEO render output [wip] bootkube: use localhost endpoint for kas-o and etcdctl Feb 20, 2020
@hexfusion
Copy link
Contributor Author

/cherrypick release-4.4

@openshift-cherrypick-robot

@hexfusion: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion changed the title [wip] bootkube: use localhost endpoint for kas-o and etcdctl bootkube: use localhost endpoint for kas-o and etcdctl Feb 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2020
@hexfusion hexfusion mentioned this pull request Feb 21, 2020
37 tasks
@hexfusion
Copy link
Contributor Author

ceo/175 landed
/test all

@hexfusion
Copy link
Contributor Author

/test e2e-aws

@@ -134,12 +132,10 @@ then
--config-output-file=/assets/etcd-bootstrap/config \
--cluster-config-file=/assets/manifests/cluster-network-02-config.yml

sed -i "s/__BOOTSTRAP_IP__/${BOOTSTRAP_IP}/" /opt/openshift/manifests/etcd-host-service-endpoints.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lack of this is probably creating an invalid manifest, but I haven't checked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah possible, looking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[subsets[0].addresses[0].ip: Invalid value: "BOOTSTRAP_IP": must be a valid IP address

@hexfusion
Copy link
Contributor Author

/test e2e-aws

@openshift-ci-robot
Copy link
Contributor

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 ff9e2e5 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-ovirt ff9e2e5 link /test e2e-ovirt
ci/prow/e2e-openstack ff9e2e5 link /test e2e-openstack
ci/prow/e2e-aws-fips ff9e2e5 link /test e2e-aws-fips
ci/prow/e2e-libvirt ff9e2e5 link /test e2e-libvirt
ci/prow/e2e-aws ff9e2e5 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Feb 24, 2020

I opened #3175 which I think may gain more traction.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2020
@openshift-ci-robot
Copy link
Contributor

@hexfusion: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Contributor Author

/close

@openshift-ci-robot
Copy link
Contributor

@hexfusion: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants