Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809190: Return the correct error after uploading OpenStack image #3163

Merged
merged 1 commit into from Feb 25, 2020
Merged

Bug 1809190: Return the correct error after uploading OpenStack image #3163

merged 1 commit into from Feb 25, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Feb 22, 2020

Now we return "err" from the previous call, but instead we should return "res.Err".

@Fedosin
Return the correct error after uploading OpenStack image
56edd43 
Now we return "err" from the previous call, but instead we should
return "res.Err".
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Feb 22, 2020

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Feb 23, 2020

/retest

@tomassedovic
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@pierreprinetti
Copy link
Member

/lgtm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 986b661 into openshift:master Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 56edd43 link /test e2e-aws-upgrade
ci/prow/e2e-libvirt 56edd43 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 56edd43 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin Fedosin changed the title Return the correct error after uploading OpenStack image Bug 1809190: Return the correct error after uploading OpenStack image Mar 2, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1809190 has been moved to the MODIFIED state.

In response to this:

Bug 1809190: Return the correct error after uploading OpenStack image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 2, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2020
Merged
@openshift-cherrypick-robot
Copy link

@Fedosin: new pull request created: #3212

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@tomassedovic tomassedovic

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Fedosin @tomassedovic @openshift-ci-robot @pierreprinetti @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot