New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyphen missing in a command to punch the initramfs into the virtual reader #3171
hyphen missing in a command to punch the initramfs into the virtual reader #3171
Conversation
…eader Signed-off-by: Pedro Ibáñez <pedro@redhat.com>
@@ -225,7 +225,7 @@ $ vmur pun -r -u <z/vm guest id> -N kernel.img rhcos-<version>-installer-kernel | |||
# punch the parameter file created in an earlier step | |||
$ vmur pun -r -u <z/vm guest id> -N generic.parm <bootstrap,master,worker>.prm | |||
# punch the initramfs into the virtual reader | |||
$ vmur pun -r -u <z/vm guest id> N initrd.img rhcos-<version>-installer-initramfs.img | |||
$ vmur pun -r -u <z/vm guest id> -N initrd.img rhcos-<version>-installer-initramfs.img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
/assign @wking |
/approve @dbenoit17 drop in an lgtm when you are comfortable. /unassign @wking |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, dbenoit17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@ptrnull: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Small issue in a hyphen missing, without it the command fails and the initramfs file can not be punched to the virtual reader.
Signed-off-by: Pedro Ibáñez pedro@redhat.com