Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyphen missing in a command to punch the initramfs into the virtual reader #3171

Merged

Conversation

ptrnull
Copy link

@ptrnull ptrnull commented Feb 24, 2020

Small issue in a hyphen missing, without it the command fails and the initramfs file can not be punched to the virtual reader.

Signed-off-by: Pedro Ibáñez pedro@redhat.com

…eader

Signed-off-by: Pedro Ibáñez <pedro@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2020
@abhinavdahiya abhinavdahiya requested review from dbenoit17 and removed request for patrickdillon and jstuever February 24, 2020 17:43
@@ -225,7 +225,7 @@ $ vmur pun -r -u <z/vm guest id> -N kernel.img rhcos-<version>-installer-kernel
# punch the parameter file created in an earlier step
$ vmur pun -r -u <z/vm guest id> -N generic.parm <bootstrap,master,worker>.prm
# punch the initramfs into the virtual reader
$ vmur pun -r -u <z/vm guest id> N initrd.img rhcos-<version>-installer-initramfs.img
$ vmur pun -r -u <z/vm guest id> -N initrd.img rhcos-<version>-installer-initramfs.img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dbenoit17
Copy link
Contributor

/assign @wking

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Feb 24, 2020

/approve

@dbenoit17 drop in an lgtm when you are comfortable.

/unassign @wking

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, dbenoit17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@dbenoit17
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 96fd95d into openshift:master Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

@ptrnull: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 a665bad link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants