Give a proper error when misusing OPENSHIFT_INSTALL_AZURE_EMULATE_SINGLESTACK_IPV6

[danwinship]

If you set OPENSHIFT_INSTALL_AZURE_EMULATE_SINGLESTACK_IPV6=true but accidentally pass an IPv4 config, the install will fail with:

ERROR                                              
ERROR Error: Insufficient record blocks            
ERROR                                              
ERROR   on  line 0:                                
ERROR   (source code not available)                
ERROR                                              
ERROR At least 1 "record" blocks are required.     
ERROR                                              
ERROR Failed to read tfstate: open /tmp/openshift-install-151306092/terraform.tfstate:
no such file or directory 
FATAL failed to fetch Cluster: failed to generate asset "Cluster": failed to create
cluster: failed to apply using Terraform 

If you pass an IPv6-only install-config it will fail with an even uglier error.

This PR fixes it to instead fail in both cases with:

FATAL failed to fetch Terraform Variables: failed to generate asset "Terraform
Variables": failed to get azure Terraform variables:
OPENSHIFT_INSTALL_AZURE_EMULATE_SINGLESTACK_IPV6 requires a dual-stack install-config 

[dcbw]

/lgtm

[patrickdillon]

We need this, but I think it should live in install-config/platform validation. Perhaps somewhere around here: https://github.com/openshift/installer/blob/master/pkg/types/validation/installconfig.go#L173

[danwinship]

@patrickdillon ah, indeed. Done.

[danwinship]

/retest

[danwinship]

/retest

[patrickdillon]

/lgtm

[patrickdillon]

/assign @abhinavdahiya

Needs approve

[abhinavdahiya]

/approve

/skip

/test e2e-azure

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	4a9769f	link	/test e2e-libvirt
ci/prow/e2e-aws-fips	4a9769f	link	/test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.