Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1786363: filter out unsupported regions in Azure #3206

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 40 additions & 2 deletions pkg/asset/installconfig/azure/azure.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/pkg/errors"
survey "gopkg.in/AlecAivazis/survey.v1"

azres "github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/resources"
azsub "github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/subscriptions"
)

Expand All @@ -27,12 +28,24 @@ func Platform() (*azure.Platform, error) {
if err != nil {
return nil, errors.Wrap(err, "failed to get list of regions")
}

resourceCapableRegions, err := getResourceCapableRegions()
if err != nil {
return nil, errors.Wrap(err, "failed to get list of resources to check available regions")
}

longRegions := make([]string, 0, len(regions))
shortRegions := make([]string, 0, len(regions))
for id, location := range regions {
longRegions = append(longRegions, fmt.Sprintf("%s (%s)", id, location))
shortRegions = append(shortRegions, id)
for _, resourceCapableRegion := range resourceCapableRegions {
// filter our regions not capable of having resources created (we check for resource groups)
if resourceCapableRegion == location {
longRegions = append(longRegions, fmt.Sprintf("%s (%s)", id, location))
shortRegions = append(shortRegions, id)
}
}
}

regionTransform := survey.TransformString(func(s string) string {
return strings.SplitN(s, " ", 2)[0]
})
Expand Down Expand Up @@ -95,3 +108,28 @@ func getRegions() (map[string]string, error) {
}
return allLocations, nil
}

func getResourceCapableRegions() ([]string, error) {
session, err := GetSession()
if err != nil {
return nil, err
}

client := azres.NewProvidersClient(session.Credentials.SubscriptionID)
client.Authorizer = session.Authorizer
ctx, cancel := context.WithTimeout(context.TODO(), 30*time.Second)
defer cancel()

provider, err := client.Get(ctx, "Microsoft.Resources", "")
if err != nil {
return nil, err
}

for _, resType := range *provider.ResourceTypes {
if *resType.ResourceType == "resourceGroups" {
return *resType.Locations, nil
}
}

return []string{}, nil
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.