Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invocation of log.Errorf #3219

Merged
merged 2 commits into from Mar 3, 2020
Merged

Fix invocation of log.Errorf #3219

merged 2 commits into from Mar 3, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Mar 3, 2020

There's no need to use Errorf when there is nothing to format. In this
case, let's use logger.Error() instead.

Fedosin and others added 2 commits March 2, 2020 16:25
@Fedosin
OpenStack: return an error if load balancer deletion fails
82e9dc8 
Now if there was a failure during load balancer deletion, we do not
return anything and continue the execution, which leads to a runtime
error later.
This commit changes this behavior and returns an error immediately
if something bad happens.
@mandre
Fix invocation of log.Errorf
e5d6d7a 
There's no need to use Errorf when there is nothing to format. In this
case, let's use logger.Error() instead.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2020
@mandre mandre mentioned this pull request Mar 3, 2020
Merged
@Fedosin
Copy link
Contributor

Fedosin commented Mar 3, 2020

/lgtm
/approve
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@Fedosin
Copy link
Contributor

Fedosin commented Mar 3, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@Fedosin
Copy link
Contributor

Fedosin commented Mar 3, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@Fedosin
Copy link
Contributor

Fedosin commented Mar 3, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 58ecac3 into openshift:master Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt e5d6d7a link /test e2e-ovirt
ci/prow/e2e-aws-scaleup-rhel7 e5d6d7a link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt e5d6d7a link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre mandre deleted the openstack-logger branch April 15, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mandre @Fedosin @openshift-ci-robot @openshift-bot @openshift-merge-robot