Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1810196: Use RPM for UPI dependencies #3234

Merged
merged 1 commit into from Mar 5, 2020
Merged

Bug 1810196: Use RPM for UPI dependencies #3234

merged 1 commit into from Mar 5, 2020

Conversation

pierreprinetti
Copy link
Member

The use of pip is not supported.

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1810196, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1810196: Use RPM for UPI dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2020
@pierreprinetti
Copy link
Member Author

/label platform/openstack
/cc @mandre @adduarte

@pierreprinetti
Copy link
Member Author

/uncc mtnbikenc fabianofranz

@pierreprinetti
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member Author

/retest

mandre
mandre reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we depend on a particular version of one of these packages?

docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved
@pierreprinetti
Copy link
Member Author

pierreprinetti commented Mar 5, 2020 •
edited

Do we depend on a particular version of one of these packages?

I am not aware of any recent changes that affect what we need here. The CI job will tell us more, once ready to fly.

(We will need to find a solution for soft-anti-affinity, but that's not in 4.4)

@mandre
Copy link
Member

mandre commented Mar 5, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2020
racedo
racedo reviewed Mar 5, 2020
View reviewed changes
docs/user/openstack/install_upi.md Outdated
source venv/bin/activate
pip install -U pip
pip install -r requirements.txt
yum install python-openstackclient ansible python-openstacksdk python-netaddr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this from a RHEL 8 box customers need to know where to install the packages from. RHEL8 also uses python3-$pkgname so we should document this:

sudo subscription-manager register # if not done already
sudo subscription-manager attach --pool=$YOUR_POOLID # if not done already
sudo subscription-manager repos --disable=* # if not done already

Then enable the right RHEL8 repos:
sudo subscription-manager repos --enable=rhel-8-for-x86_64-baseos-rpms --enable=openstack-16-tools-for-rhel-8-x86_64-rpms --enable=ansible-2.8-for-rhel-8-x86_64-rpms --enable=rhel-8-for-x86_64-appstream-rpms

Then install the packages:
sudo yum install python3-openstackclient ansible python3-openstacksdk python3-netaddr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have added what you suggest. Do you mind having a look?

@pierreprinetti
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2020
@pierreprinetti
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
@mandre
Copy link
Member

mandre commented Mar 5, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Bug 1810196: Use RPM for UPI dependencies
532f583 
The use of pip is not supported.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@mandre
Copy link
Member

mandre commented Mar 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020
@pierreprinetti
Copy link
Member Author

Incorporate comment by @zokahn https://bugzilla.redhat.com/show_bug.cgi?id=1810202#c2

Maybe also add
sudo alternatives --set python /usr/bin/python3
to be able to just call python. Some of the scripts on the install doc use them

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c9fb096 into openshift:master Mar 5, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged. Bugzilla bug 1810196 has been moved to the MODIFIED state.

In response to this:

Bug 1810196: Use RPM for UPI dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2020
Merged
@openshift-cherrypick-robot
Copy link

@pierreprinetti: new pull request created: #3246

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 5, 2020 •
edited

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 532f583 link /test e2e-libvirt
ci/prow/e2e-aws-fips 532f583 link /test e2e-aws-fips
ci/prow/e2e-aws-scaleup-rhel7 532f583 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti pierreprinetti deleted the remove_pip branch March 5, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@racedo racedo racedo left review comments

@adduarte adduarte Awaiting requested review from adduarte

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @openshift-ci-robot @openshift-cherrypick-robot @mandre @openshift-bot @racedo @openshift-merge-robot