New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal: update docs to indicate stable IP's are required #3237
Conversation
The doc currently "strongly reccomends" static DHCP reservations in machineCIDR. This updates the doc to be explicit that IP's must be stable.
/label platform/baremetal |
/lgtm |
@hexfusion @mfojtik this is important for the etcd operator as we shift to IP addresses. The clouds provide this guarantee on private network IP addresses which we use from the node.status to determine IPs to use. The etcd operator will have manual recovery directions (not easy, not awful) if all IP addresses change and automatic updates for single IP address changes. This update means that etcd will be consistently stable on metal. |
/lgtm |
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1567/ |
/approve This is just docs. Can I approve my own PR? 😄 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
The doc currently "strongly reccomends" static DHCP reservations in
machineCIDR. This updates the doc to be explicit that IP's must be
stable.