[WIP] data/data/azure/vnet: force dependencies #3251
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -17,6 +17,8 @@ resource "azurerm_subnet" "master_subnet" { | |||
| ] : cidr.value if cidr.include] | |||
| virtual_network_name = local.virtual_network | |||
There was a problem hiding this comment.
Since we are using the output of the created resource, we already depend on it... why do we need the explicit depend?
There was a problem hiding this comment.
I agree that you would /think/ that would handle the issue. Some googling around says otherwise. I agree this is a crude hack, which is why I've labeled the PR a WIP. Nobody seems to know for sure if this is a dependency problem within terraform, or a parallelism problem with Azure. One thing for sure, is that if you set parallelism=1, then all problems go away ;-) Here are some issues on github for reference:
hashicorp/terraform-provider-azurerm#3780
hashicorp/terraform-provider-azurerm#4285
hashicorp/terraform-provider-azurerm#3673
There was a problem hiding this comment.
We should also try to fix this upstream to make sure we don't need this depends on later
|
/test e2e-azure |
2 similar comments
|
/test e2e-azure |
|
/test e2e-azure |
|
/retest |
|
/test e2e-azure |
Force the subnet resource to depend on the virtual network. This eliminates the dreaded "AnotherOperationInProgress" error. https://bugzilla.redhat.com/show_bug.cgi?id=1809346
jhixson74
force-pushed
the
master_azure_bz_1809346
branch
from
b98da55
to
11a3813
Compare
|
/test e2e-azure |
|
/retest |
1 similar comment
|
/retest |
|
This error is no longer happening in the CI or when creating clusters.. seems like azure fixed something in the back end. So maybe we don't need this PR.. |
|
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Force the subnet resource to depend on the virtual network. This eliminates the
dreaded "AnotherOperationInProgress" error.
https://bugzilla.redhat.com/show_bug.cgi?id=1809346