Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: reuse the existing function to get glance public URL #3285

Merged
merged 1 commit into from Mar 13, 2020
Merged

OpenStack: reuse the existing function to get glance public URL #3285

merged 1 commit into from Mar 13, 2020
+8 −15

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Mar 12, 2020

Now we parse the service catalog manually, but it is better to reuse the existing function from gophercloud, that does the same.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2020
@Fedosin
OpenStack: reuse the existing function to get glance public URL
84ab7d1 
Now we parse the service catalog manually, but it is better to
reuse the existing function from gophercloud, that does the same.
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 12, 2020

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 12, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 12, 2020

/test e2e-openstack

@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/retest

@pierreprinetti
Copy link
Member

/test e2e-openstack

@pierreprinetti
Copy link
Member

/approve
/label platform/openstack

@openshift-ci-robot openshift-ci-robot added platform/openstack approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/retest

@Fedosin Fedosin closed this Mar 13, 2020
@Fedosin Fedosin reopened this Mar 13, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/test e2e-aws-upgrade

@mandre
Copy link
Member

mandre commented Mar 13, 2020

/lgtm
Definitely better!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/test e2e-aws-upgrade

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierreprinetti
Copy link
Member

/test e2e-aws-upgrade

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/test e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2020 •
edited

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 84ab7d1 link /test e2e-ovirt
ci/prow/e2e-aws-fips 84ab7d1 link /test e2e-aws-fips
ci/prow/e2e-libvirt 84ab7d1 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 13, 2020

/test e2e-aws-upgrade

@openshift-merge-robot openshift-merge-robot merged commit 578abd8 into openshift:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti approved these changes

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Fedosin @pierreprinetti @mandre @openshift-bot @openshift-ci-robot @openshift-merge-robot