Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/baremetal: remove nss package as it's no longer needed #3289

Merged
merged 1 commit into from Mar 16, 2020

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 13, 2020

These images are failing to build internally for OSE due to missing the
nss wrapper package.

The underyling problem we are seeing when trying to use the
baremetal-installer image in CI to ssh to the packet server is that
user ID's are generated dynamically. This results in errors like this
when attempting to use SSH:

    No user exists for uid 102400000

The way most CI containers work around this is to echo a valid user to
/etc/passwd, as /etc/passwd is left writeable. The base images for
OpenShift now do this by default, so we can remove nss entirely.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2020
@stbenjam
Copy link
Member Author

/label platform/baremetal
/cc @honza @andfasano

@honza
Copy link
Member

honza commented Mar 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@metal3ci
Copy link

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1626/

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2020
These images are failing to build internally for OSE due to missing the
nss wrapper package.

The underyling problem we are seeing when trying to use the
baremetal-installer image in CI to ssh to the packet server is that
user ID's are generated dynamically. This results in errors like this
when attempting to use SSH:

        No user exists for uid 102400000

The way most CI containers work around this is to echo a valid user to
/etc/passwd, as /etc/passwd is left writeable. The base images for
OpenShift now do this by default, so we can remove nss entirely.
@stbenjam stbenjam changed the title images/baremetal: remove nss package and make passwd writeable images/baremetal: remove nss package as it's no longer needed Mar 14, 2020
@metal3ci
Copy link

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1630/

@honza
Copy link
Member

honza commented Mar 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2020
@hardys
Copy link
Contributor

hardys commented Mar 16, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0a22450 into openshift:master Mar 16, 2020
@openshift-ci-robot
Copy link
Contributor

@stbenjam: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 9bfd4ad link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants