Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permissions.go: configure crendential check with installer session #3295

Merged
merged 2 commits into from Mar 17, 2020
Merged

permissions.go: configure crendential check with installer session #3295

merged 2 commits into from Mar 17, 2020

Conversation

abhinavdahiya
Copy link
Contributor

previously the credential checker created an independent session, therefore all the configuration
done by installer like increasing MaxRetries etc were skipped.

@abhinavdahiya
Copy link
Contributor Author

/hold 337fef0 is WIP vendor update based on openshift/cloud-credential-operator#167

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2020
@abhinavdahiya
Copy link
Contributor Author

/test e2e-aws

@abhinavdahiya
vendor update cloud-credential-operator
23333a6 
```
$ go version
go version go1.14 linux/amd64

$ go mod edit -require github.com/openshift/cloud-credential-operator@master
$ go mod tidy
warning: ignoring symlink /home/adahiya/go/src/github.com/openshift/installer/pkg/asset/store/data
go: downloading github.com/openshift/cloud-credential-operator v0.0.0-20200316201045-d10080b52c9e
$ go mod vendor
```

brings in changes from openshift/cloud-credential-operator#167
@abhinavdahiya
permissions.go: configure crendential check with installer session
9a8f3f0 
previously the credential checker created an independent session, therefore all the configuration
done by installer like increasing MaxRetries etc were skipped.
@abhinavdahiya
Copy link
Contributor Author

/hold cancel

23333a6 brings in correct vendor update.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@abhinavdahiya
Copy link
Contributor Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya abhinavdahiya mentioned this pull request Mar 17, 2020
Merged
10 tasks
@openshift-merge-robot openshift-merge-robot merged commit 34f6670 into openshift:master Mar 17, 2020
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 9a8f3f0 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member

wking commented Mar 17, 2020

Mitigates rhbz#1767936.

@sdodson
Copy link
Member

sdodson commented Jun 24, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@sdodson: #3295 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	go.mod
A	go.sum
A	vendor/modules.txt
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): vendor/modules.txt deleted in HEAD and modified in vendor update cloud-credential-operator. Version vendor update cloud-credential-operator of vendor/modules.txt left in tree.
CONFLICT (modify/delete): go.sum deleted in HEAD and modified in vendor update cloud-credential-operator. Version vendor update cloud-credential-operator of go.sum left in tree.
CONFLICT (modify/delete): go.mod deleted in HEAD and modified in vendor update cloud-credential-operator. Version vendor update cloud-credential-operator of go.mod left in tree.
Patch failed at 0001 vendor update cloud-credential-operator

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@abhinavdahiya @patrickdillon @openshift-ci-robot @openshift-bot @wking @sdodson @openshift-cherrypick-robot @openshift-merge-robot