Bug 1840496: [baremetal] Remove DNS VIP #3304
Conversation
Use of this field is being removed in [0] and [1]. Once those two PRs have merged there will no longer be any use for it. 0: openshift/machine-config-operator#1569 1: openshift/installer#3304
|
/hold Until the dependency merges. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/cc @mandre @jcpowermac @rgolangh i think we would need something similar for openstack and vpshere and rhv |
|
@abhinavdahiya: GitHub didn't allow me to request PR reviews from the following users: need, similar, for, and, rhv, we, would, think, i, something, openstack. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use of this field is being removed in [0] and [1]. Once those two PRs have merged there will no longer be any use for it. 0: openshift/machine-config-operator#1569 1: openshift/installer#3304
openshift-ci-robot
added
the
needs-rebase
|
/label platform/baremetal |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1698/ |
openshift-ci-robot
removed
the
needs-rebase
|
/hold cancel This is only changing baremetal-specific things, so the ovirt failure shouldn't be related. |
openshift-ci-robot
removed
the
do-not-merge/hold
Use of this setting is being removed in [0]. Once that goes in we can remove it from the installer as well. 0: openshift/machine-config-operator#1569
|
/retest |
|
@cybertron we really need this PR to be merged. |
|
/test e2e-metal-ipi |
|
This has previously passed e2e-metal-ipi, so I'm fine with this merging. Please file a BZ targetting 4.5 and update the title. /lgtm @abhinavdahiya PTAL, this touches files we don't have approval on. |
|
lets merge. please please please :) |
|
@rlopez133 FYI - this may affect baremetal-deploy / documentation |
@stbenjam thanks for the heads up, what version would be impacted here? |
cybertron
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@cybertron: This pull request references Bugzilla bug 1840496, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh @rlopez133 This would be for 4.5. |
openshift-ci-robot
added
bugzilla/valid-bug
|
@cybertron: This pull request references Bugzilla bug 1840496, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cybertron: All pull requests linked via external trackers have merged: openshift/installer#3304. Bugzilla bug 1840496 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was removed in openshift/installer#3304
This was removed in openshift/installer#3304
This was removed in openshift/installer#3304
This was removed in openshift/installer#3304
* Store local copy of release info We retrive this several times, so caching locally will be faster, and also provides a useful reference for debugging * Replace OPENSHIFT_VERSION reference with function This variable isn't always set, in particular in CI, so instead of relying on it, we can use a new openshift_version function which derives the version from the locally cached release info. * Only specify dnsVIP for < 4.5 This was removed in openshift/installer#3304
* Simplify additional_trust_bundle() * Pass ca via path instead of via env vars Improve readability Fix loca-bmo script (openshift-metal3#1144) (openshift-metal3#1084) Co-authored-by: Andrea Fasano <60063538+andfasano@users.noreply.github.com> Fix incorrect group name (openshift-metal3#1155) `whoami` does not always match the group name for the user. Use `id -gn` to set the group name properly. Also create GROUP environment variable and replace USER where appropriate for chown commands. Signed-off-by: Melvin Hillsman <mrhillsman@redhat.com> Additional trust bundle (openshift-metal3#1152) * Adding the option to add certs to install-config.yaml * Add ADDITIONAL_TRUST_BUNDLE to the config_example.sh * Avoid additionalTrustBundle duplication & move from sed to awk When MIRROR_IMAGES is set or when using ipv6 (this is always true for ipv6) additionalTrustBundle section gets created, so give precedence to MIRROR_IMAGES CA * In case MIRROR_IMAGES is set, concat ADDITIONAL_TRUST_BUNDLE Co-authored-by: Aviel Yosef <ayosef@redhat.com> Account for podman version < 2.0.0 (openshift-metal3#1151) The default for CentOS 8 is 1.6.4 which does not support units in `podman wait -i`. Add a version check to support both. Follow-up to commit 42af610. Update version detection and make dnsVIP conditional (openshift-metal3#1146) * Store local copy of release info We retrive this several times, so caching locally will be faster, and also provides a useful reference for debugging * Replace OPENSHIFT_VERSION reference with function This variable isn't always set, in particular in CI, so instead of relying on it, we can use a new openshift_version function which derives the version from the locally cached release info. * Only specify dnsVIP for < 4.5 This was removed in openshift/installer#3304
Use of this setting is being removed in [0]. Once that goes in we
can remove it from the installer as well.
0: openshift/machine-config-operator#1569