Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1819132: Convert ansible module to openstackcli #3318

Merged
merged 1 commit into from Mar 31, 2020
Merged

Bug 1819132: Convert ansible module to openstackcli #3318

merged 1 commit into from Mar 31, 2020

Conversation

MaysaMacedo
Copy link
Contributor

This commit ensures we rely on the openstackcli
instead of ansible modules for UPI.

@MaysaMacedo
Copy link
Contributor Author

/label platform/openstack

@MaysaMacedo MaysaMacedo force-pushed the convert-ansible-module-to-openstackcli branch from ceafc21 to 0bd0aae Compare March 19, 2020 12:23
@jstuever
Copy link
Contributor

/uncc @jstuever
/cc @adduarte

@openshift-ci-robot openshift-ci-robot requested review from adduarte and removed request for jstuever March 19, 2020 18:58
@pierreprinetti
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@pierreprinetti
Copy link
Member

@MaysaMacedo
Do you plan on removing your (amazing... 😢 ) modules and the /library folder in the same PR?

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Mar 20, 2020 •
edited

@MaysaMacedo
Do you plan on removing your (amazing... cry ) modules and the /library folder in the same PR?

Yes. Note that this PR is still missing a few things:

  • Bugzilla for backport
  • Convert ansible modules needed for destroy cluster to openstackCLI

@MaysaMacedo MaysaMacedo changed the title Convert ansible module to openstackcli wip: Convert ansible module to openstackcli Mar 20, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2020
@MaysaMacedo MaysaMacedo force-pushed the convert-ansible-module-to-openstackcli branch 8 times, most recently from f5d1e2c to eca1839 Compare March 26, 2020 13:21
@MaysaMacedo MaysaMacedo changed the title wip: Convert ansible module to openstackcli Convert ansible module to openstackcli Mar 26, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2020
@MaysaMacedo
Copy link
Contributor Author

/retest

/cc @luis5tb @dulek

@MaysaMacedo MaysaMacedo force-pushed the convert-ansible-module-to-openstackcli branch from eca1839 to 989ae9b Compare March 26, 2020 16:29
@MaysaMacedo MaysaMacedo mentioned this pull request Mar 26, 2020
Merged
10 tasks
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Bugzilla bug 1819132, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 31, 2020
@MaysaMacedo MaysaMacedo force-pushed the convert-ansible-module-to-openstackcli branch from e3eaf7d to 13a6200 Compare March 31, 2020 11:06
@dulek
Copy link
Contributor

dulek commented Mar 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@MaysaMacedo
Copy link
Contributor Author

/hold
Try one improvement before merging

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@MaysaMacedo MaysaMacedo force-pushed the convert-ansible-module-to-openstackcli branch from 13a6200 to 5fe8de1 Compare March 31, 2020 13:02
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@MaysaMacedo
Convert ansible module to openstackcli
7a8be42 
This commit ensures we rely on the openstackcli
instead of ansible modules for UPI.
@MaysaMacedo MaysaMacedo force-pushed the convert-ansible-module-to-openstackcli branch from 5fe8de1 to 7a8be42 Compare March 31, 2020 13:04
@MaysaMacedo
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@luis5tb
Copy link
Contributor

luis5tb commented Mar 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2020 •
edited

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 0bd0aae link /test e2e-metal-ipi
ci/prow/e2e-aws-scaleup-rhel7 5fe8de1 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt 7a8be42 link /test e2e-libvirt
ci/prow/e2e-openstack 7a8be42 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a5e607b into openshift:master Mar 31, 2020
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: All pull requests linked via external trackers have merged: openshift/installer#3318. Bugzilla bug 1819132 has been moved to the MODIFIED state.

In response to this:

Bug 1819132: Convert ansible module to openstackcli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@MaysaMacedo: #3318 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	docs/user/openstack/install_upi.md
M	upi/openstack/04_control-plane.yaml
M	upi/openstack/down-04_control-plane.yaml
Falling back to patching base and 3-way merge...
Removing upi/openstack/library/os_trunk.py
Removing upi/openstack/library/os_tag.py
Removing upi/openstack/library/os_delete_ports_on_router.py
Removing upi/openstack/library/os_delete_network_resources.py
Removing upi/openstack/library/os_delete_lb_resources.py
Removing upi/openstack/library/os_create_svc_subnet.py
Removing upi/openstack/library/os_create_subnet_pool.py
Auto-merging upi/openstack/down-04_control-plane.yaml
CONFLICT (content): Merge conflict in upi/openstack/down-04_control-plane.yaml
Auto-merging upi/openstack/04_control-plane.yaml
Auto-merging docs/user/openstack/install_upi.md
Patch failed at 0001 Convert ansible module to openstackcli

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ghost
ghost reviewed Apr 3, 2020
View reviewed changes
upi/openstack/down-06_load-balancers.yaml

- set_fact:
versions: "{{ octavia_versions.json.versions | selectattr('id', 'match', 'v2.5') | map(attribute='id') | list }}"
when: os_networking_type == "Kuryr"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indent here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreprinetti pierreprinetti pierreprinetti left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@adduarte adduarte Awaiting requested review from adduarte

@dulek dulek Awaiting requested review from dulek

@luis5tb luis5tb Awaiting requested review from luis5tb

Assignees

@dulek dulek

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MaysaMacedo @jstuever @pierreprinetti @dulek @openshift-bot @openshift-ci-robot @luis5tb @openshift-cherrypick-robot @openshift-merge-robot