-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1759617: vendor: bump tf provider aws to v2.54.0 #3323
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is my lack of understanding
gomod
but even after reading https://golang.org/cmd/go/#hdr-Pseudo_versions I don't understand why this has prefixv1.60-1.0-
and is not simplyv2.54.0
as the commit is part of a release?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any
v2.*.*
or greater requires module to have a/v2
(or corresponding) suffix.. since tf aws provider is usingv2
tags but no module the go mod fails...so afaik using commit as target like
go mod edit -require github.com/terraform-providers/terraform-provider-aws@commit-sha
makes the go mod to change that commit to a psuedo verion based on latest v1 tag..