Bug 1812950: generate metadata before tfvars #3329
Conversation
Now we generate terraform config and create resources for OpenStack first, and only then we create the metadata.json file. In case the resources were not created because of an error, we get garbage in the system. And the installer cannot remove it because the metadata file has not been generated yet. This commit creates the file before the generation of terraform config.
|
@Fedosin: This pull request references Bugzilla bug 1812950, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test e2e-openstack |
3 similar comments
|
/test e2e-openstack |
|
/test e2e-openstack |
|
/test e2e-openstack |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Tests are green |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Fedosin: All pull requests linked via external trackers have merged: openshift/installer#3329. Bugzilla bug 1812950 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Fedosin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Now we generate terraform config and create resources for OpenStack first, and only then we create the metadata.json file.
In case the resources were not created because of an error, we get garbage in the system. And the installer cannot remove it because the metadata file has not been generated yet.
This commit creates the file before the generation of terraform config.