images/baremetal: save rhcos.json in container image #3330
Conversation
For the baremetal platform, we need to know where the images are in order to mirror them. Especially for IPv6 environments where we may not have outbound internet access to download the images. Typically, we download the rhcos.json from the sha reported by `openshift-install version` but this doesn't work in CI, where PR's are always rebased on master and the sha reported doesn't exist on GitHub. This is a temporary workaround until the machine OS content is part of the release image itself.
stbenjam
force-pushed
the
preserve-rhcos-json-baremetal
branch
from
5bdedb6
to
897cf89
Compare
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
since this seems like the docker file for CI only, this is fine for now. I would make sure this doesn't end up in any image we deliver as part of release-image or directly to users. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
For the baremetal platform, we need to know where the images are in
order to mirror them. Especially for IPv6 environments where we may not
have outbound internet access to download the images.
Typically, we download the rhcos.json from the sha reported by
openshift-install versionbut this doesn't work in CI, where PR's arealways rebased on master (or their target branch) and the sha reported doesn't exist on GitHub.
This is a temporary workaround until the machine OS content is part of
the release image itself.