Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere ipi: set vm name to extra config - guestinfo.hostname #3342

Merged
merged 1 commit into from Mar 30, 2020
Merged

vsphere ipi: set vm name to extra config - guestinfo.hostname #3342

merged 1 commit into from Mar 30, 2020

Conversation

jcpowermac
Copy link
Contributor

When creating masters create a new key/value within extra
config named guestinfo.hostname. This value will be used
by vmtoolsd that will grab the value to be set to the hostname.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2020
@jcpowermac
Copy link
Contributor Author

Along with this PR, these are also required for this to work:
openshift/machine-config-operator#1579
openshift/machine-api-operator#537

@jcpowermac jcpowermac changed the title [wip] vsphere ipi: set vm name to extra config - guestinfo.hostname vsphere ipi: set vm name to extra config - guestinfo.hostname Mar 25, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2020
@mtnbikenc
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@jcpowermac
Copy link
Contributor Author

/assign @abhinavdahiya

@enxebre
Copy link
Member

enxebre commented Mar 27, 2020

cc @alexander-demichev for awareness.

@abhinavdahiya
Copy link
Contributor

/test e2e-vpshere

abhinavdahiya
abhinavdahiya reviewed Mar 27, 2020
View reviewed changes
data/data/vsphere/master/main.tf
"guestinfo.ignition.config.data.encoding" = "base64"
"guestinfo.hostname" = "${var.cluster_id}-${var.name}-${count.index}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also set this for bootstrap host. it wouldn't be applied today.. but maybe when rhcos does support that by default it would be nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I can update it to be set

@abhinavdahiya
Copy link
Contributor

/test e2e-vsphere

@jcpowermac
vsphere ipi: set vm name to extra config - guestinfo.hostname
de30cad 
When creating masters create a new key/value within extra
config named `guestinfo.hostname`.  This value will be used
by vmtoolsd that will grab the value to be set to the hostname.
@jcpowermac jcpowermac force-pushed the vsphere_ipi_guestinfo_hostname branch from 147446c to de30cad Compare March 27, 2020 21:18
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@abhinavdahiya
Copy link
Contributor

/test e2e-vpshere

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@abhinavdahiya
Copy link
Contributor

/test e2e-vsphere

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcpowermac
Copy link
Contributor Author

From testing IPI, hostname set as expected:

# jcallen @ magnesium in ~/go/src/github.com/openshift/installer on git:vsphere_ipi_guestinfo_hostname o [14:05:35] 
$ ssh core@139.178.89.241 -i ~/.ssh/openshift-dev.pem
Warning: Permanently added '139.178.89.241' (ECDSA) to the list of known hosts.
Red Hat Enterprise Linux CoreOS 44.81.202003062006-0
  Part of OpenShift 4.4, RHCOS is a Kubernetes native operating system
  managed by the Machine Config Operator (`clusteroperator/machine-config`).

WARNING: Direct SSH access to machines is not recommended; instead,
make configuration changes via `machineconfig` objects:
  https://docs.openshift.com/container-platform/4.4/architecture/architecture-rhcos.html

---
[core@jcallen-kjhc9-master-0 ~]$ hostnamectl 
   Static hostname: jcallen-kjhc9-master-0
         Icon name: computer-vm
           Chassis: vm
        Machine ID: 6b1b0850ec334f8fa44472f4301f3785
           Boot ID: 657c47d323624451a55591925113befc
    Virtualization: vmware
  Operating System: Red Hat Enterprise Linux CoreOS 44.81.202003062006-0 (Ootpa)
            Kernel: Linux 4.18.0-147.5.1.el8_1.x86_64
      Architecture: x86-64
[core@jcallen-kjhc9-master-0 ~]$

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt de30cad link /test e2e-libvirt
ci/prow/e2e-vsphere de30cad link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 947d751 into openshift:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

@mtnbikenc mtnbikenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jcpowermac @mtnbikenc @enxebre @abhinavdahiya @openshift-ci-robot @openshift-bot @openshift-merge-robot