Bug 1816995: OpenStack: create server group only once #3355
Conversation
|
@Fedosin: This pull request references Bugzilla bug 1816995, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
Now we create the server group in OpenStack Machines asset, but it is called twice: from Bootstrap Ignition Config and from Terraform Variables. It leads to the fact that we create two server groups during installation. This commit makes the server group creation idempotent.
Fedosin
force-pushed
the
fix_server_groups
branch
from
d4440df
to
e6f173b
Compare
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@Fedosin: This pull request references Bugzilla bug 1816995, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve I like how you made MachineSpec generation idempotent. Good job! However, I could not verify this:
As far as I could see, tfvars generation does not actually re-generate the MachineSpec: it unmarshals the pre-generated YAML. The mystery of why the function is called twice remains, at least to me, unsolved. /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/uncc jcpowermac jstuever |
|
/label platform/openstack |
|
In the openstack CI, the installer created only one server group, and all the masters were attached to it. 👍 /lgtm |
|
@Fedosin: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Fedosin: All pull requests linked via external trackers have merged: openshift/installer#3355. Bugzilla bug 1816995 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Now we create the server group in OpenStack Machines asset, but it is called twice: from Bootstrap Ignition Config and from Terraform Variables. It leads to the fact that we create two server groups
during installation.
This commit makes the server group creation idempotent.