Use "default-ingress-cert", not "router-ca" #3380
Conversation
|
@Miciah If this needs backported to 4.4, might as well open the 4.5 bug and associate it with this PR. |
We can either backport to 4.4 or keep the deprecated |
|
qq: moving not found from move ahead to failure for the router cert, is there a case where the default ca cert will not be created? |
ping @Miciah |
The ingress operator always creates |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
As of OpenShift 4.4.0, the "router-ca" configmap is deprecated, and the "default-ingress-cert" configmap should be used instead. * cmd/openshift-install/create.go (addRouterCAToClusterCA): Replace use of "router-ca" with use of "default-ingress-cert". Return not-found errors to caller. * docs/user/troubleshooting.md: Update references to "router-ca".
|
Rebased. |
Miciah
force-pushed
the
use-default-ingress-cert-not-router-ca
branch
from
76ff340
to
81a0904
Compare
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
As of OpenShift 4.4.0, the
router-caconfigmap is deprecated, and thedefault-ingress-certconfigmap should be used instead.cmd/openshift-install/create.go(addRouterCAToClusterCA): Replace use ofrouter-cawith use ofdefault-ingress-cert. Return not-found errors to caller.docs/user/troubleshooting.md: Update references to "router-ca".Thanks @stlaz for finding the issue! openshift/cluster-ingress-operator#377 (comment)