Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall: allow for azure uninstall to succeed for missing rg #3416

Merged

Conversation

staebler
Copy link
Contributor

@staebler staebler commented Apr 6, 2020

When running an Azure uninstall for a cluster that has already been deleted, the uninstall fails due to an error deleting the resource group. This change accepts an already-deleted resource group as a successful uninstall of the resource group.

https://issues.redhat.com/browse/CO-863

When running an Azure uninstall for a cluster that has already been
deleted, the uninstall fails due to an error deleting the resource
group. This change accepts an already-deleted resource group as a
successful uninstall of the resource group.

https://issues.redhat.com/browse/CO-863
@abhinavdahiya
Copy link
Contributor

/test e2e-azure

/assign @jhixson74

@openshift-ci-robot
Copy link
Contributor

@staebler: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 32ed681 link /test e2e-libvirt
ci/prow/e2e-openstack 32ed681 link /test e2e-openstack
ci/prow/e2e-azure 32ed681 link /test e2e-azure
ci/prow/e2e-aws-scaleup-rhel7 32ed681 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/retest

/lgtm

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-scaleup-rhel7
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-azure
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-ipi
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test shellcheck
  • /test tf-fmt
  • /test tf-lint
  • /test unit
  • /test verify-vendor
  • /test yaml-lint

Use /test all to run all jobs.

In response to this:

/retest

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@abhinavdahiya
Copy link
Contributor

/retest

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit f3831e1 into openshift:master Apr 14, 2020
@staebler staebler deleted the successive_azure_uninstall branch April 15, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants