Bug 1821653: Fix LB deletion for lbs with same or status pending #3419
Conversation
|
/label platform/openstack |
|
/lgtm |
MaysaMacedo
changed the title
|
@MaysaMacedo: This pull request references Bugzilla bug 1821653, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/assign @pierreprinetti |
This commit ensures the lb ID is used instead of the name when deleting a lb, as openstack allows multiple load balancers with same name to coexist. Also, it ensures the deletion of lb with status different than ERROR or ACTIVE to be skipped.
MaysaMacedo
force-pushed
the
fix-destroy-lb
branch
from
536c2cc
to
a30fe87
Compare
|
/retest |
|
/lgtm |
| with_items: "{{ lbs_tagged.json.loadbalancers }}" | ||
| when: | ||
| - os_networking_type == "Kuryr" | ||
| - versions | length > 0 | ||
| - '"PENDING" not in item.provisioning_status' |
There was a problem hiding this comment.
noob question: why not "pending"? What if it is an early teardown, and the LB didn't have the time to come up?
There was a problem hiding this comment.
@pierreprinetti Octavia does not allow to delete LB with provioning status PENDING-*, it would return an error. This way we avoid it.
There was a problem hiding this comment.
I added a note to the docs, for the user to retry the playbook once the lb is active.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@MaysaMacedo: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@MaysaMacedo: All pull requests linked via external trackers have merged: openshift/installer#3419. Bugzilla bug 1821653 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick 4.4 |
|
@MaysaMacedo: cannot checkout 4.4: error checking out 4.4: exit status 1. output: error: pathspec '4.4' did not match any file(s) known to git. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@MaysaMacedo: new pull request created: #3431 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit ensures the lb ID is used instead of the name
when deleting a lb, as openstack allows multiple load balancers
with same name to coexist. Also, it ensures the deletion of lb
with status different than ERROR or ACTIVE to be skipped.