Updates to fix DNS error for compact cluster worker nodes #3425
Conversation
|
/test e2e-metal |
| @@ -184,7 +184,20 @@ resource "aws_route53_record" "ctrlp_int" { | |||
| records = ["${local.ctrp_records}"] | |||
| } | |||
|
|
|||
| resource "aws_route53_record" "apps" { | |||
| resource "aws_route53_record" "apps_noworker" { | |||
There was a problem hiding this comment.
something we might want to look at, is
- making sure all the nodes, control-plane + compute become part of the *.app DNS
- use route53 health checks to make sure only active nodes with ingress routers become active as DNS response.
There was a problem hiding this comment.
I'll talk to you on Monday to understand your comments and resolve it. I'm able to successfully bring up a cluster which has both control plane and workers running on the same hosts.
There was a problem hiding this comment.
The suggestion was only a recommendation. this is not important and only for future work
/approve
|
/test e2e-metal |
1 similar comment
|
/test e2e-metal |
varungur
force-pushed
the
compact-metal-cluster
branch
from
4cd5a47
to
74d049f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-metal |
|
/retest |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@varungur: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
@sdodson - Please review these changes.