Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1822701: OpenStack: Set vrrp protocol number instead of name #3435

Merged
merged 1 commit into from Apr 18, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Apr 9, 2020

If VRRP plugin is disabled in neutron, then Terraform fails to fetch the desired protocol number.

To prevent the issue this patch explicitly sets the protocol number to 112 for the sg rules.

For more information:
https://docs.openstack.org/api-ref/network/v2/index.html?expanded=create-security-group-rule-detail

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1822701, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822701: OpenStack: Set port instead of vrrp protocol name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamemilio
Copy link

/apporove
/hold until it passes CI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@iamemilio
Copy link

/approve
/label platform/openstack

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
If VRRP plugin is disabled in neutron, then Terraform fails to fetch
the desired protocol number.

To prevent the issue this patch explicitly sets the protocol number
to 112 for the sg rules.

For more information:
https://docs.openstack.org/api-ref/network/v2/index.html?expanded=create-security-group-rule-detail
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 9, 2020

/test e2e-openstack

@Fedosin Fedosin changed the title Bug 1822701: OpenStack: Set port instead of vrrp protocol name Bug 1822701: OpenStack: Set vrrp protocol number instead of name Apr 9, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 9, 2020

/test e2e-openstack

2 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 10, 2020

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Apr 10, 2020

/test e2e-openstack

@mandre
Copy link
Member

mandre commented Apr 10, 2020

/test e2e-openstack
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 11, 2020

/test e2e-openstack

2 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 11, 2020

/test e2e-openstack

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 12, 2020

/test e2e-openstack

@iamemilio
Copy link

/retest

1 similar comment
@iamemilio
Copy link

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 15, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mandre
Copy link
Member

mandre commented Apr 16, 2020

/hold
Please refrain from merging changes without green e2e-openstack job.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2020
@iamemilio
Copy link

/retest

@iamemilio
Copy link

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@Fedosin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 38fe2fa link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a126ecc into openshift:master Apr 18, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: All pull requests linked via external trackers have merged: openshift/installer#3435. Bugzilla bug 1822701 has been moved to the MODIFIED state.

In response to this:

Bug 1822701: OpenStack: Set vrrp protocol number instead of name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Apr 30, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@mandre: new pull request created: #3528

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants