Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1822858: vsphere ipi: tag virtual machine created when importing ova #3443

Merged
merged 1 commit into from Apr 13, 2020
Merged

Bug 1822858: vsphere ipi: tag virtual machine created when importing ova #3443

merged 1 commit into from Apr 13, 2020

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Apr 13, 2020 •
edited

  • Add rest client
  • Add function attachTag. This function creates a TagManager
    that will attach a tag to virtual machine managedobject
  • Modify terraform resource schema
  • Use provided Folder to place virtual machine (template) in.
  • Update terraform to use tag for imported virtual machine

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2020
@jcpowermac jcpowermac changed the title [wip] bug 1822858 vsphere ipi: tag virtual machine created when importing ova [wip] Bug 1822858: vsphere ipi: tag virtual machine created when importing ova Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: An error was encountered searching for bug 1822858 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1822858?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[wip] Bug 1822858: vsphere ipi: tag virtual machine created when importing ova

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Bugzilla bug 1822858, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac jcpowermac changed the title [wip] Bug 1822858: vsphere ipi: tag virtual machine created when importing ova Bug 1822858: vsphere ipi: tag virtual machine created when importing ova Apr 13, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2020
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Apr 13, 2020 •
edited

This PR has been tested and resolves the issue of the "template" virtual machine not deleted when destroying the cluster.

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Bugzilla bug 1822858, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822858: vsphere ipi: tag virtual machine created when importing ova

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

/test e2e-vsphere

@jcpowermac
vsphere ipi: tag virtual machine created when importing ova
0cc9f43 
- Add rest client
- Add function `attachTag`. This function creates a TagManager
that will attach a tag to virtual machine managedobject
- Modify terraform resource schema
- Use provided Folder to place virtual machine (template) in.
- Update terraform to use `tag` for imported virtual machine
@abhinavdahiya
Copy link
Contributor

/test e2e-vsphere

@abhinavdahiya
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 e925f6d link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-vsphere 6fd6f47 link /test e2e-vsphere
ci/prow/e2e-openstack 0cc9f43 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cca02e2 into openshift:master Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: All pull requests linked via external trackers have merged: openshift/installer#3443. Bugzilla bug 1822858 has been moved to the MODIFIED state.

In response to this:

Bug 1822858: vsphere ipi: tag virtual machine created when importing ova

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcpowermac @openshift-ci-robot @abhinavdahiya @openshift-bot @openshift-merge-robot