New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1822858: vsphere ipi: tag virtual machine created when importing ova #3443
Conversation
@jcpowermac: An error was encountered searching for bug 1822858 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jcpowermac: This pull request references Bugzilla bug 1822858, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR has been tested and resolves the issue of the "template" virtual machine not deleted when destroying the cluster. |
@jcpowermac: This pull request references Bugzilla bug 1822858, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-vsphere |
pkg/terraform/exec/plugins/vsphereprivate/resource_vsphereprivate_import_ova.go
Outdated
Show resolved
Hide resolved
pkg/terraform/exec/plugins/vsphereprivate/resource_vsphereprivate_import_ova.go
Outdated
Show resolved
Hide resolved
pkg/terraform/exec/plugins/vsphereprivate/resource_vsphereprivate_import_ova.go
Outdated
Show resolved
Hide resolved
- Add rest client - Add function `attachTag`. This function creates a TagManager that will attach a tag to virtual machine managedobject - Modify terraform resource schema - Use provided Folder to place virtual machine (template) in. - Update terraform to use `tag` for imported virtual machine
/test e2e-vsphere |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jcpowermac: All pull requests linked via external trackers have merged: openshift/installer#3443. Bugzilla bug 1822858 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
attachTag
. This function creates a TagManagerthat will attach a tag to virtual machine managedobject
tag
for imported virtual machine