[fcos] Cherrypick few 4.4 fixes #3448
Conversation
The UPI documentation recommends keeping the worker Machineset in case the user wants to create compute machines via the machine API. However, the Machineset won't work unless the `image` property is updated to the user-defined value. This change adds a recommendation to update the OS image in case the user wants to use the installer-provisioned Machineset.
Following objects are still present in the cluster, after deletion is completed: - Cinder volumes from PVs - Swift container for image registry (bootstrap container is correctly deleted)
The Boostrap Ignition file needs to be edited before it's uploaded. Before this change, the documentation described the "upload" step before the "edit" step.
Now if the function fails, we stop the installation immediately, but it's better to retry several times before finally stopping the installation.
Signed-off-by: Roy Golan <rgolan@redhat.com>
|
Just noting that /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws |
|
/override ci/prow/e2e-vsphere |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This also updates to latest MCO.
/cc @LorbusChris