Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ensure health probes are HTTPS in Azure #3450

Closed

Conversation

fabianofranz
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
@fabianofranz
Copy link
Member Author

/test e2e-azure

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabianofranz
You can assign the PR to them by writing /assign @fabianofranz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabianofranz
Copy link
Member Author

/test e2e-azure

@abhinavdahiya
Copy link
Contributor

I think we need to use HTTP(S) for the ign server too right ?

resource "azurerm_lb_probe" "internal_lb_probe_sint" {
name = "sint-probe"
resource_group_name = var.resource_group_name
interval_in_seconds = 5
number_of_probes = 2
loadbalancer_id = azurerm_lb.internal.id
port = 22623
protocol = "TCP"
}

@fabianofranz
Copy link
Member Author

/test e2e-azure

@fabianofranz
Copy link
Member Author

/test e2e-azure

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 14, 2020

@fabianofranz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 9ce984b link /test e2e-ovirt
ci/prow/e2e-openstack 9ce984b link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 9ce984b link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure 9ce984b link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabianofranz
Copy link
Member Author

Closing in favor of #3600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants